Skip to content

Corrected a few tests of "Phone Number" (emacs-lisp #465) #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025

Conversation

borderite
Copy link
Contributor

  • Revised the following tests using the canonical test data, as suggested by BNAndras.

    cleans-number-test
    cleans-numbers-with-dots-test
    valid-when-11-digits-and-first-is-1-test

  • Revised the following tests specific for "Phone Number" to conform the requirements for phone numbers.

    area-code-test
    pprint-test
    pprint-full-us-phone-number-test

- Revised the following tests using the canonical test data.

    cleans-number-test
    cleans-numbers-with-dots-test
    valid-when-11-digits-and-first-is-1-test

- Revised the following tests specific for "Phone Number" to conform
the requirements for phone numbers.

    area-code-test
    pprint-test
    pprint-full-us-phone-number-test
Copy link

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@fapdash fapdash merged commit a054b41 into exercism:main Apr 14, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants