Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make user_id foreign key for github team members #7027

Merged
merged 11 commits into from
Aug 14, 2024

Conversation

ErikSchierboom
Copy link
Member

No description provided.

@@ -1,14 +1,16 @@
class Github::TeamMember::Create
include Mandate

initialize_with :user_id, :team_name
initialize_with :github_uid, :team_name
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made it explicit that this is the GitHub UID.

Copy link
Member

@iHiD iHiD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this looks loads better now. Thanks dude.

@ErikSchierboom ErikSchierboom merged commit 636f873 into main Aug 14, 2024
37 of 38 checks passed
@ErikSchierboom ErikSchierboom deleted the fix-github-user-foreign-keys branch August 14, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants