Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Sobo Tutorial #508

Merged
merged 2 commits into from
Feb 10, 2025
Merged

Custom Sobo Tutorial #508

merged 2 commits into from
Feb 10, 2025

Conversation

jduerholt
Copy link
Contributor

This PR adds a notebook that shows how to setup sobo strategies with custom objective manipulations.

@jduerholt jduerholt requested a review from LukasHebing January 31, 2025 11:09
@LukasHebing
Copy link
Contributor

A bit of information is missing for me to be able to understand the example:

  • The parameters of f need to be explained: What will be passed as samples, callables, ...
def f(samples, callables, weights, X):
...
  • The function for getting the index, should be explained a bit:
feature2index, _ = strategy.domain.inputs._get_transform_info(
    strategy.input_preprocessing_specs
)
feat_idx = feature2index["x_1"][0]

@jduerholt
Copy link
Contributor Author

Thx, for the review. I will work on it ;)

@jduerholt
Copy link
Contributor Author

@LukasHebing : I implemented your suggestions. It is ready for rereview ;)

@LukasHebing
Copy link
Contributor

Great, good example :)

@jduerholt jduerholt merged commit cd27bf5 into main Feb 10, 2025
9 of 10 checks passed
@jduerholt jduerholt deleted the tutorial/custom_sobo branch February 10, 2025 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants