-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2468 Reimplement due_date.rb #129
Open
pchopelas
wants to merge
17
commits into
expertiza:main
Choose a base branch
from
akuldevali:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-back-end into create-due-date-model
created due date table and model.
… and review_allowed. Also refactored subclasses' get_next_due_dates into factory method in superclass. Small fix for due dates table as well
added attr_accessors for teammate_review_allowed, submission_allowed,…
…red schema and migration to match existing table, added tests for AssignmentDueDate and validation, renamed TopicDueDate file
Updates from Mentor Meeting
Reimplemented TopicDueDate
…-cases rRefactors and test cases
updated some comments to be more descriptive
refactored copy and added test. small cleanup on validation tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for E2468 Reimplement due_date.rb