Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2483. Reimplement Notification Controller and Model #142

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

E2483. Reimplement Notification Controller and Model #142

wants to merge 18 commits into from

Conversation

VaibhaviShetty23
Copy link

This pull request reimplements the notification system to enhance role-based access control and improve data management. Key updates include:

  • Development of a new Notification model and controller to handle CRUD operations.
  • Role-based access control ensuring notifications are accessible only to authorized users (students, instructors, TAs).
  • Association of notifications with specific courses and users, enabling segregation by role and course enrollment.
  • RESTful API endpoints for efficient notification delivery and management.
  • Comprehensive testing for models, controllers, and edge cases to ensure robustness.

Soubarnica Somangali Suresh and others added 18 commits November 21, 2024 00:42
Initial setup: scaffolded Notification model and controller, migrated…
ebb6ca7 
… changes to db
@aditikilledar
basic controller functions added. need to be tested
6229847
Changed notifications_controller.rb to resolve the error: root@7ebe25…
90eb208 
…641ae9:/app# rails zeitwerk:check

                                                          Hold on, I am eager loading the application.
                                                          expected file app/controllers/api/v1/notifications_controller.rb to define constant Api::V1::NotificationsController
included the API and VI module in notification
7ea56dc
@VaibhaviShetty23
Added validations and scope
c3eaf58
@VaibhaviShetty23
Added notification routes and authorization_helper. Added some new me…
6ff8d54 
…thods in notification controller
@VaibhaviShetty23
Update routes.rb
61251c9
@VaibhaviShetty23
Updated notification_controller for API based framework
7bf79d0
@aditikilledar
fixed db to reflect course_name instead of course_id
fe3325f 
- in notifications schema, FK is course_name instead of course_id
- added new SQL script to escalate permissions to access reimplementation_test table as user dev that runs at every build
@SoubarnicaSuresh
Added config.routes.rb custom action routes, fixed routing spec with …
0f4ae9d 
…correct namespace for NotificationController, added notification model spec and successfully ran tests.
@SoubarnicaSuresh
Merge pull request #1 from SoubarnicaSuresh/test_model
e1859e7 
Added config.routes.rb custom action routes, fixed routing spec with …
@VaibhaviShetty23
added notification in swagger api docs
770cd96
@SoubarnicaSuresh
Merge branch 'main' into controller_reimp
56f84ac
@SoubarnicaSuresh
Merge branch 'controller_reimp' of https://github.com/SoubarnicaSures…
05ad5e4 
…h/reimplementation-back-end into controller_reimp
@SoubarnicaSuresh
Merge pull request #2 from SoubarnicaSuresh/controller_reimp
46a31fb 
Merge branch controller_reimp to Main
@SoubarnicaSuresh
Added controller method for toggle_active, Added controller rspec tes…
3c818bf 
…t cases
@VaibhaviShetty23
Changed the controller from sessions based to JWT based development
c8b7f9c 
Sessions does not save and we need to use a token based approach in the backend.
@VaibhaviShetty23
Merge branch 'main' of https://github.com/SoubarnicaSuresh/reimplemen…
9eaef48 
…tation-back-end
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VaibhaviShetty23 @aditikilledar @SoubarnicaSuresh