Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new reward_learning experiment #478

Open
wants to merge 37 commits into
base: master
Choose a base branch
from

Conversation

gewimmer
Copy link

Hi!

I finally added my long-term reward learning experiment.

@vsoch
Copy link
Member

vsoch commented Jul 13, 2016

Great! You will need to fix the linting errors that are shown here https://circleci.com/gh/expfactory/expfactory-experiments/950 and then push to the branch to run the check again. When all tests pass, we can merge into the branch.

@vsoch
Copy link
Member

vsoch commented Jul 14, 2016

Looks like listing is good - you need to add your new experiment to the circle.yml file. Just follow the others for example!

@vsoch
Copy link
Member

vsoch commented Jul 28, 2016

Hey so for commit messages you might want to be specific about what the commit changed, so coming back in the future you can find changes more efficiently!

@gewimmer
Copy link
Author

Definitely agree! In this case, I'm just updating the list.js files
(repeatedly) to add more participant lists. Will note that in the future.

On Thu, Jul 28, 2016 at 10:21 AM, Vanessa Sochat [email protected]
wrote:

Hey so for commit messages you might want to be specific about what the
commit changed, so coming back in the future you can find changes more
efficiently!


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#478 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQW2pNoaxQ-d5Svi8B6IdCWObe737rEKks5qaOU0gaJpZM4JL8F_
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants