fix: remove pysbd and sentence segmenting #1826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
jjmachan
approved these changes
Jan 9, 2025
jjmachan
reviewed
Jan 9, 2025
src/ragas/metrics/_bleu_score.py
Outdated
Comment on lines
35
to
37
| reference, response = sample.reference, sample.response | ||
| assert isinstance(reference, str), "Expecting a string" | ||
| assert isinstance(response, str), "Expecting a string" |
There was a problem hiding this comment.
the fact that we have to use the assert here feels not good. The other problem is the error message, ideally it should tell them what to do about it, not sure if that is easy to define here
There was a problem hiding this comment.
I have edited the message to make it clear, but this is an API design problem. The metric expects valid response and reference but in SIngleTurnSample they are optional.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes:
#1783
#1736