Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(prompt/mixin): Add name property and add it to saving/loading path. #1853

Merged
merged 4 commits into from
Jan 23, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 16 additions & 7 deletions src/ragas/prompt/mixin.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,9 @@ class PromptMixin:
eg: [BaseSynthesizer][ragas.testset.synthesizers.base.BaseSynthesizer], [MetricWithLLM][ragas.metrics.base.MetricWithLLM]
"""

def _get_prompts(self) -> t.Dict[str, PydanticPrompt]:
name: str = ""

def _get_prompts(self) -> t.Dict[str, PydanticPrompt]:
prompts = {}
for key, value in inspect.getmembers(self):
if isinstance(value, PydanticPrompt):
Expand Down Expand Up @@ -90,10 +91,13 @@ def save_prompts(self, path: str):
prompts = self.get_prompts()
for prompt_name, prompt in prompts.items():
# hash_hex = f"0x{hash(prompt) & 0xFFFFFFFFFFFFFFFF:016x}"
prompt_file_name = os.path.join(
path, f"{prompt_name}_{prompt.language}.json"
)
prompt.save(prompt_file_name)
if self.name == "":
file_name = os.path.join(path, f"{prompt_name}_{prompt.language}.json")
else:
file_name = os.path.join(
path, f"{self.name}_{prompt_name}_{prompt.language}.json"
)
prompt.save(file_name)
tim-hilde marked this conversation as resolved.
Show resolved Hide resolved

def load_prompts(self, path: str, language: t.Optional[str] = None):
"""
Expand All @@ -113,7 +117,12 @@ def load_prompts(self, path: str, language: t.Optional[str] = None):

loaded_prompts = {}
for prompt_name, prompt in self.get_prompts().items():
prompt_file_name = os.path.join(path, f"{prompt_name}_{language}.json")
loaded_prompt = prompt.__class__.load(prompt_file_name)
if self.name == "":
file_name = os.path.join(path, f"{prompt_name}_{language}.json")
else:
file_name = os.path.join(
path, f"{self.name}_{prompt_name}_{language}.json"
)
loaded_prompt = prompt.__class__.load(file_name)
loaded_prompts[prompt_name] = loaded_prompt
return loaded_prompts
Loading