Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] No longer require owner field for SDK >= 53 or canary #2835

Conversation

wschurman
Copy link
Member

@wschurman wschurman commented Jan 23, 2025

Why

As of expo/expo#34209, we no longer need to include the owner field in app config since packages in the SDK no longer use it.

This is needed before the second PR in that stack can land (expo/expo#34210) since it uses eas cli.

How

Update condition and test.

Test Plan

Run test.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@wschurman wschurman requested review from brentvatne and ide January 23, 2025 02:15
@wschurman wschurman marked this pull request as ready for review January 23, 2025 02:15
Copy link

Subscribed to pull request

File Patterns Mentions
**/* @szdziedzic, @khamilowicz, @sjchmiela, @radoslawkrzemien

Generated by CodeMention

Copy link
Member Author

Will wait for expo/expo#34209 to land before landing this.

Copy link

github-actions bot commented Jan 23, 2025

Size Change: +884 B (0%)

Total Size: 53.4 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53.4 MB +884 B (0%)

compressed-size-action

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.32%. Comparing base (1b78407) to head (113b251).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2835      +/-   ##
==========================================
+ Coverage   52.32%   52.32%   +0.01%     
==========================================
  Files         588      588              
  Lines       23145    23148       +3     
  Branches     4849     4850       +1     
==========================================
+ Hits        12108    12111       +3     
  Misses      10062    10062              
  Partials      975      975              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shaneboyar
Copy link

This somewhat relates to my PR: #2825

@wschurman wschurman force-pushed the @wschurman/01-22-_eas-cli_no_longer_require_owner_field_for_sdk_53_or_canary branch from 6c18481 to 113b251 Compare February 5, 2025 02:35
Copy link

github-actions bot commented Feb 5, 2025

✅ Thank you for adding the changelog entry!

@wschurman wschurman merged commit 6f2fc7c into main Feb 5, 2025
10 checks passed
@wschurman wschurman deleted the @wschurman/01-22-_eas-cli_no_longer_require_owner_field_for_sdk_53_or_canary branch February 5, 2025 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants