-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[eas-cli] No longer require owner field for SDK >= 53 or canary #2835
[eas-cli] No longer require owner field for SDK >= 53 or canary #2835
Conversation
Subscribed to pull request
Generated by CodeMention |
Will wait for expo/expo#34209 to land before landing this. |
Size Change: +884 B (0%) Total Size: 53.4 MB
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2835 +/- ##
==========================================
+ Coverage 52.32% 52.32% +0.01%
==========================================
Files 588 588
Lines 23145 23148 +3
Branches 4849 4850 +1
==========================================
+ Hits 12108 12111 +3
Misses 10062 10062
Partials 975 975 ☔ View full report in Codecov by Sentry. |
This somewhat relates to my PR: #2825 |
packages/eas-cli/src/commandUtils/context/contextUtils/getProjectIdAsync.ts
Outdated
Show resolved
Hide resolved
6c18481
to
113b251
Compare
✅ Thank you for adding the changelog entry! |
Why
As of expo/expo#34209, we no longer need to include the owner field in app config since packages in the SDK no longer use it.
This is needed before the second PR in that stack can land (expo/expo#34210) since it uses eas cli.
How
Update condition and test.
Test Plan
Run test.