Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] add update group id for fingerprint:compare #2851

Merged

Conversation

quinlanj
Copy link
Member

@quinlanj quinlanj commented Jan 31, 2025

Why

Add support for users accidentally passing in update group id into fingerprint:compare instead of update id.

How

Added support for handling update group IDs in the fingerprint comparison command by:

  • Attempting to fetch updates using the provided ID as an update group ID
  • If successful and there's only one update, using that update directly
  • If multiple updates exist in the group, prompting the user to select the specific platform/update
  • Falling back to the original update ID logic if the group ID lookup fails
  • Adding helpful error messages that include the direct URL to find the correct update ID

Test Plan

  • EXPO_STAGING=1 ~/Documents/eas-cli/packages/eas-cli/bin/run fingerprint:compare --update-id ed36a46b-6cc7-4f49-88df-e6ffb66f22d2
  • EXPO_STAGING=1 ~/Documents/eas-cli/packages/eas-cli/bin/run fingerprint:compare --update-id ed36a46b-6cc7-4f49-88df-e6ffb66f22d2 --non-interactive

Copy link
Member Author

quinlanj commented Jan 31, 2025

Copy link

github-actions bot commented Jan 31, 2025

Size Change: -1.69 kB (0%)

Total Size: 53.4 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53.4 MB -1.69 kB (0%)

compressed-size-action

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 12.00000% with 22 lines in your changes missing coverage. Please review.

Project coverage is 52.48%. Comparing base (427c8f1) to head (676b82f).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ckages/eas-cli/src/commands/fingerprint/compare.ts 12.00% 18 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2851      +/-   ##
==========================================
- Coverage   52.54%   52.48%   -0.06%     
==========================================
  Files         589      589              
  Lines       23038    23073      +35     
  Branches     4815     4823       +8     
==========================================
+ Hits        12104    12108       +4     
- Misses       9971     9997      +26     
- Partials      963      968       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@quinlanj quinlanj force-pushed the 01-30-_eas-cli_add_update_group_id_for_fingerprint_compare branch from dac7663 to 2c35662 Compare January 31, 2025 01:56
@quinlanj quinlanj marked this pull request as ready for review January 31, 2025 01:57
Copy link

Subscribed to pull request

File Patterns Mentions
**/* @szdziedzic, @khamilowicz, @sjchmiela, @radoslawkrzemien

Generated by CodeMention

@quinlanj quinlanj force-pushed the 01-30-_eas-cli_add_update_support_for_fingerprint_compare branch from 7d0d186 to c1ab6c1 Compare January 31, 2025 20:11
@quinlanj quinlanj force-pushed the 01-30-_eas-cli_add_update_group_id_for_fingerprint_compare branch from 2c35662 to 446db61 Compare January 31, 2025 20:11
@quinlanj quinlanj changed the base branch from 01-30-_eas-cli_add_update_support_for_fingerprint_compare to graphite-base/2851 January 31, 2025 20:24
@quinlanj quinlanj force-pushed the 01-30-_eas-cli_add_update_group_id_for_fingerprint_compare branch from 446db61 to 4afda93 Compare January 31, 2025 20:25
@quinlanj quinlanj changed the base branch from graphite-base/2851 to main January 31, 2025 20:25
@quinlanj quinlanj force-pushed the 01-30-_eas-cli_add_update_group_id_for_fingerprint_compare branch from 4afda93 to 676b82f Compare January 31, 2025 20:25
@quinlanj quinlanj merged commit 77423d1 into main Jan 31, 2025
4 checks passed
Copy link
Member Author

Merge activity

  • Jan 31, 3:25 PM EST: A user merged this pull request with Graphite.

@quinlanj quinlanj deleted the 01-30-_eas-cli_add_update_group_id_for_fingerprint_compare branch January 31, 2025 20:25
Copy link

✅ Thank you for adding the changelog entry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants