Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build issues on linux and windows #220

Merged
merged 15 commits into from
Nov 21, 2024
Merged

Conversation

gabrieldonadel
Copy link
Member

@gabrieldonadel gabrieldonadel commented Nov 21, 2024

Why

Final round of testing for the Windows and linux releases

Closes ENG-12525
Closes ENG-12523

How

  • Fix vite not bundling CLI packages correctly
  • Simplify electron/forge config
  • Fix icons in linux
  • Fix orbit button not showing up in Snack when using Firefox
  • Remove inline requires from eas-shared given that this syntax is not supported by rollupjs

Test Plan

macOS
image

Linux

image

Windows

@gabrieldonadel gabrieldonadel force-pushed the @gabrieldonadel/publish branch from 60fc577 to c68303f Compare November 21, 2024 18:48
Base automatically changed from @gabrieldonadel/bump-expo to main November 21, 2024 19:27
@gabrieldonadel gabrieldonadel force-pushed the @gabrieldonadel/publish branch from c68303f to f2f24f8 Compare November 21, 2024 21:32
Copy link

linear bot commented Nov 21, 2024

@gabrieldonadel gabrieldonadel marked this pull request as ready for review November 21, 2024 22:36
@gabrieldonadel gabrieldonadel merged commit 423438f into main Nov 21, 2024
2 checks passed
@gabrieldonadel gabrieldonadel deleted the @gabrieldonadel/publish branch November 21, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants