-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: generate sitemap.xml for SEO indexing #1838
Conversation
β Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Should we consider adding urls for YouTube video and images used on website? |
Yep, images are a good idea if the tags can be generated automatically like with the pages. If we have to maintain that list of images manually, it's preferably better not to add them. YouTube videos, no, it would be something manual to maintain. |
I am okay with adding them in future updates as the website progresses. |
Why are you blocking it? That label is to prevent merging it because it depends on another change elsewhere (for example, in another repository). But I don't understand it here, why are you adding it? We cannot merge until there is an approval from someone with commit access, so it is not necessary to block it. |
Sorry I didn't put message there. I think it is best to do this after translation and fixing layout issues. Right now I am prioritizing layout issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@ShubhamOulkar the description says not to merge, do you prefer to wait a bit before removing some languages, or go ahead anyway? |
Lets move on π |
closes #1762
how to test sitemap.xml?
test results from tool
Issue
The website contains inconsistent file formats in its changelog directory, resulting in incorrect alternate URLs generated in the sitemap.xml. Specifically, the following formats are observed:
ko/changelog/4x.md, tr/changelog/4x.md, uk/CHANGELOG.md
verify issue
When selecting Korean (ko) as the language on the changelog page, the website returns a "Page Not Found" error due to the presence of 4x.md, which seems to be an incorrect file format in this context.
Edit:- This code generates 561 URLs for 17 languages including redirects. This will increase jekyll build time. Some of the languages are removed from translations.