Fix WolfSSL ChaCha20 TCP connection #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch reverts https://github.com/wolfSSL/wolfssl/pull/7859/files PR as it currently breaks ChaCha20 TCP connection with Apple ARM64 client.
xv-raihaan-m
approved these changes
Dec 3, 2024
kp-thomas-yau
added a commit
that referenced
this pull request
Dec 11, 2024
Apply the wolfSSL/wolfssl#8275 PR fix. The original revert patch was here to fix mismatched tag when we are using ChaCha20 in TCP connection. See #183
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patch reverts wolfSSL/wolfssl#7859 PR as WolfSSL 5.7.4 currently breaks ChaCha20 TCP connection from an Apple M1 Client in one of our coverage test. It turns out the PR causes "MAC did not match" in the server-side, which means the tag (used for authenticating the cipher-text) generated in the client-side is incorrect.
Motivation and Context
Revert WolfSSL wolfSSL/wolfssl#7859 change until they have an official fix
How Has This Been Tested?
Compiled new local client and it can indeed successfully connect with our server
Types of changes
Checklist:
main