Update to wolfssl 5.7.2 #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already emitted a `rerun-if-changed` for the directory itself which is highly likely to get a different `mtime` if a file within it changed, and we have not observed issues with the previous arrangements in practice, but this change should make things more explicit.
Moving from v5.6.6-stable we are picking up: https://github.com/wolfSSL/wolfssl/releases/tag/v5.7.0-stable https://github.com/wolfSSL/wolfssl/releases/tag/v5.7.2-stable (there was no 5.7.1) Our `disable-falcon-dilithium.patch` required an update, likely due to the changes in wolfSSL/wolfssl#7622.
|
Code coverage summary for dd54cea: ✅ Region coverage 58% passes |
xv-raihaan-m
approved these changes
Sep 4, 2024
| @@ -118,6 +118,8 @@ fn build_wolfssl(wolfssl_src: &Path) -> PathBuf { | |||
| .enable("supportedcurves", None) | |||
| // Enable TLS/1.3 | |||
| .enable("tls13", None) | |||
| // Enable liboqs, etc | |||
| .enable("experimental", None) | |||
There was a problem hiding this comment.
Was this flag needed even if we use liboqs instead of wolfssl builtin kyber ?
There was a problem hiding this comment.
I think so, configure script contains:
# KYBER
# Used:
# - SHA3, Shake128 and Shake256
AC_ARG_ENABLE([kyber],
[AS_HELP_STRING([--enable-kyber],[Enable KYBER (requires --enable-experimental) (default: disabled)])],
[ ENABLED_KYBER=$enableval ],
[ ENABLED_KYBER=no ]
)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving from v5.6.6-stable we are picking up:
(there was no 5.7.1)
Our
disable-falcon-dilithium.patchrequired an update, likely due to the changes in wolfSSL/wolfssl#7622.