Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow skipping dev tests #344

Merged
merged 5 commits into from
Mar 12, 2024
Merged

Allow skipping dev tests #344

merged 5 commits into from
Mar 12, 2024

Conversation

Ilia-Kosenkov
Copy link
Member

Closes #341
Skip dev tests if REXTENDR_SKIP_DEV_TESTS is set.

CGMossa
CGMossa reviewed Mar 11, 2024
View reviewed changes
tests/testthat/helper.R Outdated Show resolved Hide resolved
CGMossa
CGMossa approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@CGMossa CGMossa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I believe we should make a habit of requesting review. I never know when you're done changing a PR.

@Ilia-Kosenkov Ilia-Kosenkov merged commit a325448 into extendr:main Mar 12, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CGMossa CGMossa CGMossa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using use_dev_extendr in tests is contentious
2 participants
@Ilia-Kosenkov @CGMossa