Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update snapshot tests #355

Merged
merged 1 commit into from
May 16, 2024
Merged

Update snapshot tests #355

merged 1 commit into from
May 16, 2024

Conversation

Ilia-Kosenkov
Copy link
Member

Fix snapshot tests after xfun/knitr update.

CGMossa
CGMossa approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@CGMossa CGMossa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ilia-Kosenkov
Copy link
Member Author

I will merge, the test fails because package version was not yet updated.

@Ilia-Kosenkov Ilia-Kosenkov merged commit 938786c into extendr:main May 16, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CGMossa CGMossa CGMossa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ilia-Kosenkov @CGMossa