-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check for empty string in use_crate() #388
Conversation
How do we know that this works? Is it possible to add a test? Otherwise I'd just merge. |
yes, this function needs a test. i'll look into adding one tomorrow! |
Pasting flags and values together into single character scalars is the wrong way to pass additional arguments to |
@kbvernon one last test! can you test the optional feature? The nifty codecov tool shows that it is missing a check :) |
…into fix-use-crate
100% code cov? You're crazy for that. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
|
To address #387, this PR adds a check for empty strings when running
purrr::discard()
on thecargo_add_opts
list.