Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --print=native-static-libs when compiling #393

Merged
merged 7 commits into from
Oct 28, 2024
Merged

Add --print=native-static-libs when compiling #393

merged 7 commits into from
Oct 28, 2024

Conversation

JosiahParry
Copy link
Contributor

Per suggestion of Yutanni, we should add --print=native-static-libs which gives us insight into which linker flags need to be visible when building our crate.

If a user encounters an error building, they can check the output.

@JosiahParry JosiahParry enabled auto-merge (squash) October 27, 2024 22:33
@JosiahParry
Copy link
Contributor Author

Note that the snapshot tests are failing because between the version of {usethis} that I have 2.2.3 and the version being tested on main 3.0.0. there is a period placed at the end of the use_build_ignore() message:

-   v Adding "^src/rust/vendor$" to '.Rbuildignore'.
+   v Adding '^src/rust/vendor$' to '.Rbuildignore'
-   v Adding "src/rust/vendor" to '.gitignore'.
+   v Adding 'src/rust/vendor' to '.gitignore'

This has taken a while to debug. Perhaps we can reduce what the snapshot tests are actually testing.

@JosiahParry JosiahParry disabled auto-merge October 27, 2024 23:52
@JosiahParry
Copy link
Contributor Author

This PR also fixes the R-devel errors. It does this by adding the configure and tools/msrv.R scripts from use_cran_defaults() into the standard use_extendr().

@JosiahParry JosiahParry enabled auto-merge (squash) October 28, 2024 00:04
@JosiahParry JosiahParry disabled auto-merge October 28, 2024 00:04
@JosiahParry JosiahParry enabled auto-merge (squash) October 28, 2024 00:07
@JosiahParry JosiahParry merged commit a8d7434 into main Oct 28, 2024
19 checks passed
@JosiahParry JosiahParry deleted the linkage branch October 28, 2024 05:48
@CGMossa
Copy link
Member

CGMossa commented Oct 28, 2024

We need to make this flag additive to if it was set by the user to contain more options though.

And now that apparently all package tests are cran tests... I don't know what we do about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants