Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: increase code coverage #405

Merged
merged 1 commit into from
Nov 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions R/cran-compliance.R
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,12 @@ vendor_pkgs <- function(path = ".", quiet = FALSE, overwrite = NULL) {
local_quiet_cli(quiet)

# get path to rust folder
src_dir <- rprojroot::find_package_root_file(path, "src/rust")
src_dir <- rprojroot::find_package_root_file("src", "rust", path = path)
JosiahParry marked this conversation as resolved.
Show resolved Hide resolved

# if `src/rust` does not exist error
if (!dir.exists(src_dir)) {
cli::cli_abort(
c("{.path src/rust} cannot be found", "i" = "Did you run {.fn use_extendr}?"),
"{.path src/rust} cannot be found. Did you run {.fn use_extendr}?",
class = "rextendr_error"
)
}
Expand Down
18 changes: 10 additions & 8 deletions R/use_msrv.R
Original file line number Diff line number Diff line change
Expand Up @@ -52,14 +52,16 @@ use_msrv <- function(version, path = ".", overwrite = FALSE) {
)
})

desc_path <- rprojroot::find_package_root_file("DESCRIPTION", path = path)

if (!file.exists(desc_path)) {
cli::cli_abort(
"{.arg path} ({.path {path}}) does not contain a DESCRIPTION",
class = "rextendr_error"
)
}
desc_path <- rlang::try_fetch(
rprojroot::find_package_root_file("DESCRIPTION", path = path),
error = function(cnd) {
cli::cli_abort(
"{.arg path} ({.path {path}}) does not contain a DESCRIPTION",
class = "rextendr_error",
call = rlang::env_parent()
)
}
)

cur <- paste("Cargo (Rust's package manager), rustc", paste(">=", version))

Expand Down
2 changes: 2 additions & 0 deletions tests/testthat/test-cran-compliance.R
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ test_that("vendor_pkgs() vendors dependencies", {
skip_if_not_installed("usethis")

path <- local_package("testpkg")

expect_error(vendor_pkgs(path))
# capture setup messages
withr::local_options(usethis.quiet = FALSE)
use_extendr(path, quiet = TRUE)
Expand Down
25 changes: 25 additions & 0 deletions tests/testthat/test-rstudio-template.R
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
test_that("RStudio template generation is correct", {
pkg_name <- "extendrtest"
tmp <- file.path(tempdir(), pkg_name)

pkg <- create_extendr_package(
tmp,
roxygen = TRUE,
check_name = FALSE,
crate_name = pkg_name,
lib_name = pkg_name,
edition = "2021"
)

expected_files <- c(
"configure", "configure.win", "DESCRIPTION",
"extendrtest.Rproj", "NAMESPACE", "R/extendr-wrappers.R",
"src/entrypoint.c", "src/extendrtest-win.def",
"src/Makevars.in", "src/Makevars.ucrt", "src/Makevars.win.in",
"src/rust/Cargo.toml", "src/rust/src/lib.rs", "tools/msrv.R"
)

for (file in expected_files) {
expect_true(file.exists(file.path(tmp, file)))
}
})
12 changes: 11 additions & 1 deletion tests/testthat/test-use_msrv.R
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,22 @@ test_that("use_msrv() modifies the MSRV in the DESCRIPTION", {
withr::local_options(usethis.quiet = FALSE)

use_extendr(path, quiet = TRUE)
use_msrv("1.70", path)
expect_no_error(use_msrv("1.70", path))

d <- desc::desc("DESCRIPTION")

expect_identical(
"Cargo (Rust's package manager), rustc >= 1.70",
d$get_field("SystemRequirements")
)

expect_error(use_msrv("adksfghu", path))

expect_error(use_msrv("1.70", path = "../doesntexist"))

# when overwrite is FALSE and SystemRequirements is already set
expect_message(
use_msrv("1.65", overwrite = FALSE),
"The SystemRequirements field in the "
)
})
Loading