Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove try_save_all() #407

Merged
merged 1 commit into from
Nov 26, 2024
Merged

chore: remove try_save_all() #407

merged 1 commit into from
Nov 26, 2024

Conversation

JosiahParry
Copy link
Contributor

This PR closes #404 by removing R/try_save_all.R and its use in document(). This has the added benefit of removing rstudioapi from Suggests as well.

With this PR, rextendr::document() will no longer be responsible for saving files for users—not that it ever should've been.

@JosiahParry JosiahParry enabled auto-merge (squash) November 25, 2024 17:20
@JosiahParry JosiahParry merged commit b20d88c into main Nov 26, 2024
19 checks passed
@JosiahParry JosiahParry deleted the no-save-rstudio branch November 26, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should we be saving files on user's behalf?
2 participants