fix: make sure we don't initialize mono before calling _start #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilslice
reviewed
Oct 1, 2023
| @@ -14,11 +14,9 @@ | |||
|
|
|||
| void IsVowel(CurrentPlugin plugin, Span<ExtismVal> inputs, Span<ExtismVal> outputs, nint userData) | |||
| { | |||
| var bytes = plugin.ReadBytes(inputs[0].v.i32); | |||
| var c = (char)inputs[0].v.i32; | |||
There was a problem hiding this comment.
is there any need for a length check here?
There was a problem hiding this comment.
I don't think so, the plugin won't be able to call the host function if they don't import it with the right signature
zshipko
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we are exporting an
_initializefunction that initializes the mono runtime. This is called by the host before calling the exported functions. However, the Rust SDK seems to call_initializebefore_starttoo, which causes a problem because_startinitializes the mono runtime too.To fix this, I have changed the behavior of the PDK to NOT export
_initializeanymore. Instead, we manually initialize the mono runtime before invoking any of the exported functions. This is inline with the behavior of some of the other compilers, namely: Rustand Haskell.This has another added benefit: wasmtime refused to call plugins that had both
_initializeand_startfunctions exported. This is no longer an issue since we never export_initializeanymore