feat: accept WebAssembly.Module, Response inputs #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisdickinson
commented
Nov 27, 2023
| @@ -394,7 +394,7 @@ export async function createBackgroundPlugin( | |||
| }); | |||
| }); | |||
|
|
|||
| worker.postMessage(message, modules); | |||
| worker.postMessage(message); | |||
There was a problem hiding this comment.
We can't transfer WebAssembly.Module instances between threads, unlike ArrayBuffers.
However, that's not necessarily a bad thing! The modules are structurally cloned between threads, which means we can send them to multiple threads in the future – which will be necessary when we go to implement pooling.
`createPlugin` now accepts two additional manifest types (`response` and `module`) as well
as `Response` and `WebAssembly.Module`. There are four goals here:
1. Allow us to target the Cloudflare Workers platform. CF Workers only support
loading Wasm via `import` statements; these resolve to `WebAssembly.Module`
objects, which means we need to allow users to pass `Module`s in addition
to our other types.
2. Play nicely with V8's [Wasm caching][1]; in particular V8 will use metadata
from the `Response` to build a key for caching the results of Wasm compilation.
3. This sets us up to implement [Wasm linking][2] by allowing us to introspect
plugin modules imports and exports before instantiation.
4. And finally, resolving to modules instead of arraybuffers allows us to add
[hooks for observe-sdk][3] (especially in advance of adding [thread pooling][4]).
Because Bun lacks support for `WebAssembly.compileStreaming` and
`Response.clone()`, we provide an alternate implementation for converting a
response to a module and its metadata.
One caveat is that there's no way to get the source bytes of a
`WebAssembly.Module`, so `{module}` cannot be used with `{hash}` in a
`Manifest`.
Fixes #9
[1]: https://v8.dev/blog/wasm-code-caching#stream
[2]: #29
[3]: #3
[4]: #31
chrisdickinson
force-pushed
the
chris/20231127-allow-webassembly-modules
branch
from
07b6aa7 to
43153f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
createPluginnow accepts two additional manifest types (responseandmodule) as well asResponseandWebAssembly.Module. There are four goals here:importstatements; these resolve toWebAssembly.Moduleobjects, which means we need to allow users to passModules in addition to our other types.Responseto build a key for caching the results of Wasm compilation.Because Bun lacks support for
WebAssembly.compileStreamingandResponse.clone(), we provide an alternate implementation for converting a response to a module and its metadata.One caveat is that there's no way to get the source bytes of a
WebAssembly.Module, so{module}cannot be used with{hash}in aManifest.Fixes #9