fix: reset plugin on call #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will this reset all vars too? When the Rust implementation calls reset the vars are left untouched since they're copied into host memory. |
chrisdickinson
force-pushed
the
chris/20240724-reset-plugin-on-call
branch
from
3ab6c5d to
384e194
Compare
|
Ah, good catch! The newest changes will preserve vars across calls. I went with your initial change –moving the variable values into |
zshipko
approved these changes
Jul 25, 2024
There was a problem hiding this comment.
Ah, good catch! The newest changes will preserve vars across calls. I went with your initial change –moving the variable values into
Uint8Arrayinstances– and wiredvar_get/var_setto proxy up to the host when running in a background worker.
That complicates things a bit - but looks good!
This aligns the js-sdk with libextism behavior [1]. [1]: https://github.com/extism/extism/blob/d04e2e42bf6091aeb9a13d4cf2e64cdd86a00a28/runtime/src/plugin.rs#L509
chrisdickinson
force-pushed
the
chris/20240724-reset-plugin-on-call
branch
from
384e194 to
f12b5cf
Compare
This was referenced Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aligns the js-sdk with libextism behavior 1.