Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the URLHaus signatures URL #405

Closed
wants to merge 1 commit into from
Closed

Fix the URLHaus signatures URL #405

wants to merge 1 commit into from

Conversation

kravietz
Copy link

@perplexityjeff
Copy link
Contributor

perplexityjeff commented Jan 19, 2022

I don't think that this fix is required? As there is a section in the code that adds the database name to the url.

========================
# urlhaus Database(s)
# ========================
# Add or remove database file names between quote marks as needed.  To
# disable any urlhaus database downloads, remove the appropriate
# lines below.
declare -a urlhaus_dbs=(
### urlhaus https://urlhaus.abuse.ch/browse/
# LOW
urlhaus.ndb|LOW #  malicious URLs that are being used for malware distribution
) #END URLHAUS DATABASES

Could you explain to me why this fix is required? As per my testing I don't see any issues. There are issues regarding the setup of the urlhaus structure of the script. See the following Pull Request for that #400 and the issue #398.

@stevenhardey
Copy link

Please see my pull request at #408 this should fix your problem as the hard coding of that value will not result in the outcome you want as explained by @perplexityjeff

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants