Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated EOM and EOL hardcoded dates #121

Merged
merged 3 commits into from
Mar 15, 2024
Merged

Updated EOM and EOL hardcoded dates #121

merged 3 commits into from
Mar 15, 2024

Conversation

alongosz
Copy link
Member

@alongosz alongosz commented Mar 15, 2024

Question Answer
JIRA issue n/a
Target Ibexa version v3.3
BC breaks no

We've extended our 3.3 LTS EOM and EOL dates according to the Service Life. This PR aligns hardcoded dates used to display warning messages with that change.

I've also noticed that for OSS we check EOM date but display in a message "end of life" information. This seems to me as a copy-paste bug. Would be nice to get some confirmation on that part.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review.

@alongosz alongosz added the Bug label Mar 15, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@konradoboza konradoboza requested a review from a team March 15, 2024 11:48
Copy link
Member

@glye glye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't confirm the copypasta bug suspicion, but it seems likely.

@alongosz alongosz merged commit 954fd28 into 2.3 Mar 15, 2024
16 checks passed
@alongosz alongosz deleted the align-eom-eol branch March 15, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

6 participants