Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-31321: Dropped injecting zero-width space into ezembed(inline) elements #1151

Merged
merged 2 commits into from
Jan 22, 2020
Merged

EZP-31321: Dropped injecting zero-width space into ezembed(inline) elements #1151

merged 2 commits into from
Jan 22, 2020

Conversation

SerheyDolgushev
Copy link
Contributor

@SerheyDolgushev SerheyDolgushev commented Dec 2, 2019 •
edited by alongosz
Loading

Question Answer
Tickets EZP-31321, related to EZP-29882
Requires ezsystems/ezplatform-richtext#88
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Parent PR: ezsystems/ezplatform-richtext#88.

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@SerheyDolgushev SerheyDolgushev mentioned this pull request Dec 2, 2019
Merged
4 tasks
@SerheyDolgushev
Copy link
Contributor Author

Zero width space seems to also cause some issues with Solr indexing:

org.apache.solr.common.SolrException: Illegal character ((CTRL-CHAR,​ code 14))

@lserwatka
Copy link
Member

@alongosz @adamwojs could you have a final look on this one?

@alongosz alongosz requested a review from dew326 January 16, 2020 15:13
@alongosz alongosz changed the title Dont use zero width sapce for EZP-29882 Dropped injecting zero-width space into ezembed(inline) elements Jan 21, 2020
@alongosz alongosz changed the title Dropped injecting zero-width space into ezembed(inline) elements EZP-31321: Dropped injecting zero-width space into ezembed(inline) elements Jan 21, 2020
@alongosz alongosz force-pushed the fix_embed_zero_width_space branch from 2091e30 to 1cdf8b3 Compare January 21, 2020 11:01
@micszo micszo self-assigned this Jan 22, 2020
micszo
micszo approved these changes Jan 22, 2020
View reviewed changes
Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Approved on eZ Platform EE v2.5.8 with branches.

@micszo micszo removed their assignment Jan 22, 2020
@lserwatka lserwatka merged commit 30ea995 into ezsystems:1.5 Jan 22, 2020
@lserwatka
Copy link
Member

@dew326 could you merge it up?

@dew326
Copy link
Member

dew326 commented Jan 22, 2020

@lserwatka done

alongosz pushed a commit to ezsystems/ezplatform-richtext that referenced this pull request Jan 23, 2020
@dew326 @alongosz
EZP-31321: Dropped injecting zero-width space into ezembed(inline) el…
c569672 
…ements (#105)

Ported for eZ Platform v3.0 from ezsystems/ezplatform-admin-ui#1151
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micszo micszo micszo approved these changes

@dew326 dew326 dew326 approved these changes

@adamwojs adamwojs adamwojs approved these changes

Assignees
No one assigned
Labels
Improvement QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@SerheyDolgushev @lserwatka @dew326 @adamwojs @micszo @alongosz