Skip to content

Commit

Permalink
Removed todo items (#29)
Browse files Browse the repository at this point in the history
* Removed unused GroupProvider interface & implementations

* Removed @todo items
  • Loading branch information
bdunogier authored and Łukasz Serwatka committed Mar 29, 2019
1 parent 3c0fc30 commit 23d46eb
Show file tree
Hide file tree
Showing 10 changed files with 2 additions and 37 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,6 @@ public function prepend(ContainerBuilder $container)
/**
* Uses YamlConfigProvider to determinate what schema should be used.
*
* @todo Make it extensible to possibly get rid of Yaml based dynamic schema.
*
* @param string $configDir
*
* @return array
Expand Down
1 change: 0 additions & 1 deletion src/GraphQL/Mutation/UploadFiles.php
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,6 @@ private function createContent(array $mapping, UploadedFile $file, $locationId,
])
);

// @todo error handling
$draft = $contentService->createContent($struct, [$locationService->newLocationCreateStruct($locationId)]);
$content = $contentService->publishVersion($draft->getVersionInfo());

Expand Down
2 changes: 0 additions & 2 deletions src/GraphQL/Resolver/DomainContentMutationResolver.php
Original file line number Diff line number Diff line change
Expand Up @@ -195,8 +195,6 @@ public function deleteDomainContent(Argument $args)
);
}

// @todo check type of domain object

try {
$this->getContentService()->deleteContent($contentInfo);
} catch (API\Exceptions\UnauthorizedException $e) {
Expand Down
1 change: 0 additions & 1 deletion src/Resources/config/default_settings.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ parameters:
definition_type: RelationListFieldDefinition
value_type: RelationListFieldValue
ezrichtext:
# @todo definition_type: RichTextFieldDefinition
value_type: RichTextFieldValue
ezselection:
definition_type: SelectionFieldDefinition
Expand Down
3 changes: 0 additions & 3 deletions src/Resources/config/graphql/DomainContent.types.yml
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@ AbstractDomainContent:
type: String
resolve: "@=resolver('MainUrlAlias', [value])"

# @todo interface ?
DomainContentTypeGroup:
type: object
config:
Expand Down Expand Up @@ -105,6 +104,4 @@ DomainContentByIdentifierConnection:
sliceSize:
type: Int!
orderBy:
# @todo make an enum or object
# @todo generate
type: String
2 changes: 0 additions & 2 deletions src/Resources/config/graphql/Field.types.yml
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,6 @@ DateFieldValue:
formatted:
type: "String"
description: "Formatted date"
# @todo: refactor with a datetime resolver
resolve: "@=resolver('DateTimeFormat', [args['format'], value.value])"
args:
format:
Expand All @@ -160,7 +159,6 @@ KeywordFieldValue:
text:
type: "String"
description: "String representation of the value"
# @todo will fail, array to string conversion
resolve: "@=value"

MapLocationFieldValue:
Expand Down
5 changes: 0 additions & 5 deletions src/Resources/config/services/mutations.yml
Original file line number Diff line number Diff line change
Expand Up @@ -154,11 +154,6 @@ services:
tags:
- { name: ezplatform_graphql.fieldtype_input_handler, fieldtype: 'ezstring', inputType: 'String' }

# @todo
#EzSystems\EzPlatformGraphQL\GraphQL\Mutation\InputHandler\FieldType\Time:
# tags:
# - { name: ezplatform_graphql.fieldtype_input_handler, fieldtype: 'eztime' }

EzSystems\EzPlatformGraphQL\GraphQL\Mutation\InputHandler\FieldType\Url:
class: 'EzSystems\EzPlatformGraphQL\GraphQL\Mutation\InputHandler\FieldType\FromHash'
arguments:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,10 @@
use EzSystems\EzPlatformGraphQL\Schema\Domain\Content\Worker\BaseWorker;
use EzSystems\EzPlatformGraphQL\Schema\Worker;
use EzSystems\EzPlatformGraphQL\Schema\Builder\Input;
use EzSystems\EzPlatformGraphQL\Schema\GroupProvider;
use EzSystems\EzPlatformGraphQL\Schema\Builder;
use eZ\Publish\API\Repository\Values\ContentType\ContentType;

class DefineDomainContent extends BaseWorker implements Worker, GroupProvider
class DefineDomainContent extends BaseWorker implements Worker
{
public function work(Builder $schema, array $args)
{
Expand All @@ -33,9 +32,4 @@ protected function typeName(array $args): string
{
return $this->getNameHelper()->domainContentName($args['ContentType']);
}

public function getGroups(array $args)
{
// @todo implement me
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,10 @@
use EzSystems\EzPlatformGraphQL\Schema\Domain\Content\Worker\BaseWorker;
use EzSystems\EzPlatformGraphQL\Schema\Worker;
use EzSystems\EzPlatformGraphQL\Schema\Builder\Input;
use EzSystems\EzPlatformGraphQL\Schema\GroupProvider;
use EzSystems\EzPlatformGraphQL\Schema\Builder;
use eZ\Publish\API\Repository\Values\ContentType\ContentType;

class DefineDomainContentType extends BaseWorker implements Worker, GroupProvider
class DefineDomainContentType extends BaseWorker implements Worker
{
public function work(Builder $schema, array $args)
{
Expand All @@ -33,9 +32,4 @@ protected function typeName(array $args): string
{
return $this->getNameHelper()->domainContentTypeName($args['ContentType']);
}

public function getGroups(array $args)
{
// @todo implement me
}
}
7 changes: 0 additions & 7 deletions src/Schema/GroupProvider.php

This file was deleted.

0 comments on commit 23d46eb

Please sign in to comment.