Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor query mapper #8
base: dev
Are you sure you want to change the base?
Refactor query mapper #8
Changes from 19 commits
0dbc81e
ffa7bf7
cb3f444
83bf501
8f0ad91
4639965
4b19c66
2279ce2
a0925a7
6d9b245
75ec18d
594c2a0
832969c
8ed08be
eea3c5c
05aa445
cd4cb88
a0b555e
4494d2a
e6fab24
7184393
37dcd75
acc7834
7b22af1
d4a0b70
4cf468b
af2fbf6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually wouldn't use a class constant for that. It doesn't deduplicate much, and does so at the cost of readability. I'd use
SearchQueryMapper::class
directly inside the method.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: the advantage of this is that a query input visitor can be overridden using the key. Useful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be changed to an exception. You could add a new one to the package, in
src/Exceptions
. MaybeInvalidQueryOperatorException
?