IBX-6484: Added check if $row is empty to prevent error #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konradoboza
approved these changes
Sep 19, 2023
alongosz
reviewed
Sep 19, 2023
There was a problem hiding this comment.
Would it make sense to add some test coverage @alongosz?
We need integration test coverage reproducing exactly this issue on API level. This would help me understand if the fix is in the proper place // @mateuszdebinski
|
Kudos, SonarCloud Quality Gate passed!
|
Steveb-p
approved these changes
Sep 25, 2023
alongosz
approved these changes
Sep 26, 2023
tomaszszopinski
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v3.3we already have the same mechanism in many places, it protects against errors with the lack or inconsistency of the content version, such as for location 1
Checklist:
$ composer fix-cs).@ezsystems/engineering-team).