-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-7015: Fixed Content Type cache_keys #392
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
konradoboza
approved these changes
Nov 14, 2023
alongosz
approved these changes
Dec 4, 2023
webhdx
approved these changes
Dec 4, 2023
This was referenced Dec 4, 2023
micszo
approved these changes
Dec 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regression tests OK.
alongosz
added a commit
to ibexa/core
that referenced
this pull request
Dec 4, 2023
Cross-merged changes from ezsystems/ezplatform-kernel#392.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v3.3
Fixes issue that was introduced when cache keys where shortened:
ibexa/core@7abf760#diff-a2bccb77c1a669abe70799f430495ee174afa21189b6466169e7780815844c3c
$this->getTypeKeys
should return only keys that represent the same Content Typeself::CONTENT_TYPE_GROUP_WITH_ID_SUFFIX_IDENTIFIER
is part of $this->getGroupKeysself::CONTENT_TYPE_GROUP_WITH_BY_REMOTE_SUFFIX_IDENTIFIER
is unneeded (Content Type Groups do not have a remote id)self::CONTENT_TYPE_WITH_ID_SUFFIX_IDENTIFIER
andself::CONTENT_TYPE_WITH_BY_REMOTE_SUFFIX_IDENTIFIER
NOTE:
The command provided in https://issues.ibexa.co/browse/IBX-7015 runs without errors in v3.3 (!).
Checklist:
$ composer fix-cs
).@ezsystems/engineering-team
).