Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-7015: Fixed Content Type cache_keys #392

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

reithor
Copy link
Contributor

@reithor reithor commented Nov 9, 2023

Question Answer
JIRA issue IBX-7015
Type bug
Target Ibexa version v3.3
BC breaks no

Fixes issue that was introduced when cache keys where shortened:
ibexa/core@7abf760#diff-a2bccb77c1a669abe70799f430495ee174afa21189b6466169e7780815844c3c

  • $this->getTypeKeys should return only keys that represent the same Content Type
  • self::CONTENT_TYPE_GROUP_WITH_ID_SUFFIX_IDENTIFIER is part of $this->getGroupKeys
  • self::CONTENT_TYPE_GROUP_WITH_BY_REMOTE_SUFFIX_IDENTIFIER is unneeded (Content Type Groups do not have a remote id)
  • introduced 2 new identifiers: self::CONTENT_TYPE_WITH_ID_SUFFIX_IDENTIFIER and self::CONTENT_TYPE_WITH_BY_REMOTE_SUFFIX_IDENTIFIER

NOTE:
The command provided in https://issues.ibexa.co/browse/IBX-7015 runs without errors in v3.3 (!).

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ezsystems/engineering-team).

Copy link

sonarqubecloud bot commented Nov 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@reithor reithor marked this pull request as ready for review November 9, 2023 16:03
@reithor reithor requested a review from konradoboza November 9, 2023 16:08
@reithor reithor requested a review from a team November 9, 2023 16:15
@reithor reithor added the Bug Something isn't working label Nov 10, 2023
@konradoboza konradoboza requested a review from a team November 14, 2023 14:55
@alongosz alongosz requested a review from a team December 4, 2023 13:52
Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regression tests OK.

@reithor reithor added the Ready for MERGE To be set by author or maintainer label Dec 4, 2023
@alongosz alongosz merged commit b99066b into 1.3 Dec 4, 2023
33 checks passed
@alongosz alongosz deleted the ibx-7015_fixed_content_type_cache_keys branch December 4, 2023 15:13
alongosz added a commit to ibexa/core that referenced this pull request Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Ready for MERGE To be set by author or maintainer Ready for QA
Development

Successfully merging this pull request may close these issues.

8 participants