IBX-6965: Set preview active in the PreviewRequestListener
#395
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
| @@ -35,6 +40,8 @@ public static function getSubscribedEvents(): array | |||
| */ | |||
| public function onKernelRequest(RequestEvent $event): void | |||
| { | |||
| $this->contentPreviewHelper->setPreviewActive(true); | |||
There was a problem hiding this comment.
This change would cause every request to set preview as active, since it subscribes to all KernelEvents::REQUEST events. You need to move this to the block actually determining that it's a preview request - see L50-52.
Looks like it's not as straightforward as it seems, so please see if there's a test coverage for this subscriber and if not please add a unit one covering 2 cases: 1) it's a preview, 2) it's not a preview.
There was a problem hiding this comment.
You are obviously right, not sure what I was thinking. What is more, adding it to the lines you've mentioned won't work either as a fragment request is in fact a master request. I think this PR becomes obsolete as of now.
|
Closed in favor of https://github.com/ezsystems/ezplatform-page-builder/pull/983 |
v3.3Related PR: https://github.com/ezsystems/ezplatform-page-builder/pull/983 (not needed anymore)
Varnish/Fastly requests are handled by
PreviewRequestListener, it should set preview to active, as the name itself says.Checklist:
$ composer fix-cs).@ezsystems/engineering-team).