Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-7346: Reindexed reverse-related content after deleting source content #396

Merged
merged 3 commits into from
Dec 27, 2023

Conversation

barw4
Copy link
Member

@barw4 barw4 commented Dec 13, 2023

Question Answer
JIRA issue IBX-7346
Type bug
Target Ibexa version v3.3
BC breaks no

Currently, content that is deleted and is used in relation to other content won't be removed from search engines fields, however, it should. Therefore, in this PR, reverse relations are fetched when deleting TrashItem and later those contents are reindexed again to account for destination content deletion.

Two specific actions are handled here and those are:

  • emptyTrash
  • deleteTrashItem

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ezsystems/engineering-team).

@barw4 barw4 added the Bug Something isn't working label Dec 13, 2023
@barw4 barw4 self-assigned this Dec 13, 2023
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@barw4 barw4 marked this pull request as ready for review December 13, 2023 17:20
@barw4 barw4 requested a review from a team December 13, 2023 17:21
Copy link

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on IbexaDXP 3.3 commerce.

@adamwojs adamwojs merged commit 29489e4 into 1.3 Dec 27, 2023
23 checks passed
@adamwojs adamwojs deleted the ibx-7346-reindex-reverse-content-after-deletion branch December 27, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working QA approved
Development

Successfully merging this pull request may close these issues.

8 participants