Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-6485: Forced RichText\Rendererto utilize PermissionResolver instead of AuthorizationChecker #239

Merged
merged 2 commits into from
Oct 2, 2023
Merged

IBX-6485: Forced RichText\Rendererto utilize PermissionResolver instead of AuthorizationChecker #239

merged 2 commits into from
Oct 2, 2023

Conversation

barw4
Copy link
Member

@barw4 barw4 commented Sep 19, 2023 •
edited
Loading

Question Answer
JIRA issue IBX-6485
Improvement yes
New feature no
Target version v3.3
BC breaks no
Tests pass yes
Doc needed no

Backport of ibexa/fieldtype-richtext#118

Failing test should be fixed after #240.

TODO:

  • Implement feature.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@barw4 barw4 added Improvement New feature or request Ready for review labels Sep 19, 2023
@barw4 barw4 self-assigned this Sep 19, 2023
@barw4 barw4 requested a review from a team September 19, 2023 10:22
@konradoboza konradoboza requested review from alongosz and a team September 19, 2023 13:42
webhdx
webhdx approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@webhdx webhdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it needs a rebase. CI issue is already fixed on the main branch.

@webhdx webhdx requested a review from a team September 26, 2023 08:14
@barw4 barw4 force-pushed the ibx-6485-Renderer-PermissionResolver branch from 8944357 to bd551ab Compare September 26, 2023 08:19
@alongosz alongosz requested a review from a team September 27, 2023 14:55
tomaszszopinski
tomaszszopinski approved these changes Oct 2, 2023
View reviewed changes
Copy link

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on IbexaDXP commerce 3.3.

@alongosz alongosz merged commit ad8aed2 into 2.3 Oct 2, 2023
20 checks passed
@alongosz alongosz deleted the ibx-6485-Renderer-PermissionResolver branch October 2, 2023 11:31
@alongosz alongosz mentioned this pull request Oct 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

@konradoboza konradoboza konradoboza approved these changes

@webhdx webhdx webhdx approved these changes

@alongosz alongosz alongosz approved these changes

Assignees

@alongosz alongosz

@barw4 barw4

@konradoboza konradoboza

Labels
Improvement New feature or request QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@barw4 @alongosz @webhdx @konradoboza @tomaszszopinski