EZP-30161: Handle form token in both custom and also for historical reasons default value #1431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…easons default value Since 5.0 FormToken code has been operating in two modes: - Default pure legacy mode using `ezxform_token` as form name - Symfony mode using `_token` as form name Hoewever quite some legacy code hard codes the default name. In 5.x this inconsistancy was solved by setting Symfony to use `field_name: ezxform_token` For Platform + legacy bridge that is no longer a good default, so this changes the logic so that ezxFormToken is cable of handling both at the same time.
emodric
approved these changes
May 11, 2019
Co-Authored-By: Gunnstein Lye <[email protected]>
|
Just want to confirm it works nicely! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 5.0 ezxFormToken code has been operating in two modes:
ezxform_tokenas form name_tokenas form name (if symfony settings are in default state)However quite some legacy code hard codes the default name, at least for javacript usage.
In 5.x this inconsistency was solved by setting Symfony to use
field_name: ezxform_tokenFor Platform + legacy bridge that is no longer the case, and neither do we want to change the field_name by default. So this changes the logic so that ezxFormToken is cable of handling both at the same time.
Closes #1420
@thiagocamposviana Could you have a look and test if this solves your issue?