Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented #18185: add in share/locale/*.ini all translations of all languages supported by eZ #145

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

jdespatis
Copy link
Contributor

Several remarks:

1/ it's a proposal... However as it's already possible to have all countries in all languages thanks to country.ini, it would be nice I guess to have the same thing for the languages!

2/ the languages don't contain any reference to the country, that way, the developer may add the country or not near the language if (s)he really wants it (quite boring in fact on a bilingual website for example, to have French / English (Great Britain)... in general, the webmaster just wants to say French / English in that example)

3/ the translations have not been generated with automatic translation (which may not be accurate), they have been get by fetching the list of languages supported by Google Translate (that includes all languages supported by eZPublish), with a navigator that sequentially accepts english, then chinese, then french, etc... (use of Accept-Language header). As a result the list of translations should be accurate

Christian Pfeffer Gjengedal and others added 19 commits October 19, 2011 15:41
…unctions"

- added code before the daemon starts to check if the functions are available
- added documentation on how to override the disabled functions
…ource

Changed $matchFilesArray to the correct $matchFileArray
… extension.xml, to have same behavior as ezinfo.php
Fixed 18427: doc issue, file.ini instead of php.ini
Implemented #18381: add description/author in ezinfo/about when using extension.xml, to have same behavior as ezinfo.php
If there are no classes to generate autoloads for in extension/, a warning was thrown
about the progressbar.
@trolek
Copy link
Contributor

trolek commented Jan 11, 2012

Hi!
You send only a proposal to language name.
I think, more general would be better:

[Translation_ara-SA]
Country=
LanguageName=
CurrencyName=

[Translation_cat-ES]
Country=
LanguageName=
CurrencyName=

@jdespatis
Copy link
Contributor Author

@trolek yes you're completely right, it would be much more generic, I'll change the pull request to respect this form

However first, @bdunogier @glye @andrerom and others, what do you think about this form ? would you think at an even more generic form than this one, exposed by @trolek ?

@glye
Copy link
Member

glye commented Jan 11, 2012

I like the idea, but how do you intend to read these settings? I'm not sure if ezini() can be used to read locales from a template. Perhaps you will need to modify l10n() or add a new operator for extracting this?

There's also the question of whether the original [RegionalSettings] should be marked for deprecation, if we merge this.

peterkeung pushed a commit to peterkeung/ezpublish that referenced this pull request Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

7 participants