Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add proxy step to ezpublish install #65

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

alexsebbane
Copy link
Contributor

#009845: Add possibility to give the installer Web Proxy details

Signed-off-by: Alexandre SEBBANE [email protected]

Signed-off-by: Alexandre SEBBANE <[email protected]>
@andrerom
Copy link
Contributor

So this is needed for packages during install I guess?
There is some discussions about bundling packages in next version, but in the meantime this would be a welcome change for some :)

@alexsebbane
Copy link
Contributor Author

when you install in a company with a proxy

alex

Envoyé de mon iPhone

Le 26 mai 2011 à 18:54, andrerom [email protected] a écrit :

So this is needed for packages during install I guess?
There is some discussions about bundling packages in next version, but in the meantime this would be a welcome change for some :)

Reply to this email directly or view it on GitHub:
#65 (comment)

</div>

<p>
{"This section is used to configure how eZ Publish is connect to internet."|i18n("design/standard/setup/init")}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably be "This section is used to configure how eZ Publish connects to the Internet. This step is only needed if the server where eZ Publish will be installed needs to use a proxy to connect to Internet, otherwise you can ignore this step." The second sentence can/should also be put in the help too.

@dpobel
Copy link
Contributor

dpobel commented Jun 20, 2011

Hi Alexandre,

As promised during the conference, I had a look at your pull request. There are some issues, could you fix them ? By the way, I don't have a proxy to test, did you test that those settings are really used while downloading packages ?

Cheers

@alexsebbane
Copy link
Contributor Author

i will do that this week.

and yes , i test it in situ

<div class="setup_summary_ok">{$summary_proxy_info}</div>
{/if}
</td>
</tr>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space at the end of the line

@dpobel
Copy link
Contributor

dpobel commented Jun 22, 2011

That's better :-)
But, there are still a BOM at the beginning of :

  • design/standard/templates/setup/summary.tpl
  • kernel/setup/steps/ezstep_create_sites.php
  • kernel/setup/steps/ezstep_data.php

and some trailing whitespace and some CS issues (see inline comments)

@gggeek
Copy link
Contributor

gggeek commented Oct 22, 2011

Btw, could you mention the with issue relating to this? I'm sure there is one...

@alexsebbane
Copy link
Contributor Author

here is the correction ...

peterkeung added a commit to peterkeung/ezpublish that referenced this pull request Sep 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants