-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add proxy step to ezpublish install #65
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Alexandre SEBBANE <[email protected]>
So this is needed for packages during install I guess? |
when you install in a company with a proxy alex Envoyé de mon iPhone Le 26 mai 2011 à 18:54, andrerom [email protected] a écrit :
|
</div> | ||
|
||
<p> | ||
{"This section is used to configure how eZ Publish is connect to internet."|i18n("design/standard/setup/init")} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably be "This section is used to configure how eZ Publish connects to the Internet. This step is only needed if the server where eZ Publish will be installed needs to use a proxy to connect to Internet, otherwise you can ignore this step." The second sentence can/should also be put in the help too.
Hi Alexandre, As promised during the conference, I had a look at your pull request. There are some issues, could you fix them ? By the way, I don't have a proxy to test, did you test that those settings are really used while downloading packages ? Cheers |
i will do that this week. and yes , i test it in situ |
<div class="setup_summary_ok">{$summary_proxy_info}</div> | ||
{/if} | ||
</td> | ||
</tr> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Space at the end of the line
That's better :-)
and some trailing whitespace and some CS issues (see inline comments) |
Btw, could you mention the with issue relating to this? I'm sure there is one... |
here is the correction ... |
#009845: Add possibility to give the installer Web Proxy details
Signed-off-by: Alexandre SEBBANE [email protected]