Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #018337: REST index missing module repository activation #72

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

nfrp
Copy link
Contributor

@nfrp nfrp commented Jun 16, 2011

No description provided.

@oms
Copy link
Contributor

oms commented Jun 21, 2011

On 2nd thought, would it work for you @nfrp, if you included the module list setup directly in your controller, as to not enforce the coupling between eZModule and the newer rest endpoint?

@lolautruche
Copy link
Contributor

I think the eZModule activation is needed since it appears to be quite common (I had this issue a couple of times on custom REST controllers and the problem is quite confusing...)
So I'd vote for the merge :)

@nfrp
Copy link
Contributor Author

nfrp commented Jun 27, 2011

@oms @lolautruche i also believe that making content creation from REST transparent should help here. This patch makes it transparent. The patch itself is maybe not the best way to do it, but on the principle i think the feature is important.

@andrerom
Copy link
Contributor

andrerom commented Aug 9, 2011

After some though I think I would vote -1 myself. rest is ment to be used with public api eventually, so when it is this patch will be removed thus breaking all code that relies on it, better to break early during development then break during upgrade possible on prod.

@nfrp
Copy link
Contributor Author

nfrp commented Nov 2, 2011

Now that we moved ahead on creating the PHP API, was there any move on the subject ? In other words, can we make available a temporary solution for people to use the REST api in W mode ?

Cheers guys,

@andrerom
Copy link
Contributor

andrerom commented Nov 2, 2011

See comment above, if people want to use the old "api" then they it is safer that they do as much old api init code in their own code as possible as that init code will not be part of rest api 2.0 witch uses public api.

@nfrp
Copy link
Contributor Author

nfrp commented Nov 2, 2011

Ok for the low-quality workaround.

I would recommend updating the various tutorials with this instruction. It cost me some debug time to figure-out what went wrong, we should help other developers not waste this time. The old API will still be used for some time until the brand new PHP + REST API is released & stable, and people will want to make mobile applications in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants