Skip to content

Commit

Permalink
IBX-596: As a QA I want to change php-cs occurrences into check-cs fo…
Browse files Browse the repository at this point in the history
…r consistency
  • Loading branch information
Steveb-p authored Jul 2, 2021
2 parents c9de2a5 + 66ac74e commit 85e1882
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 9 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,4 +45,4 @@ jobs:
run: composer run-script phpstan

- name: Run code style check
run: composer run-script php-cs -- --format=checkstyle | cs2pr
run: composer run-script check-cs -- --format=checkstyle | cs2pr
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
"scripts": {
"fix-cs": "php-cs-fixer fix -v --config=.php_cs --show-progress=estimating",
"phpstan": "phpstan analyse -c phpstan.neon",
"php-cs": "php-cs-fixer fix -v --diff --config=.php_cs --dry-run --show-progress=estimating",
"check-cs": "php-cs-fixer fix -v --diff --config=.php_cs --dry-run --show-progress=estimating",
"test": "phpunit -vc phpunit.xml"
},
"extra": {
Expand Down
19 changes: 12 additions & 7 deletions phpstan-baseline.neon
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ parameters:
path: src/bundle/Controller/ContentController.php

-
message: "#^Parameter \\#1 \\$string of static method EzSystems\\\\EzRecommendationClient\\\\Helper\\\\ParamsConverterHelper\\:\\:getArrayFromString\\(\\) expects string, string\\|null given\\.$#"
message: "#^Parameter \\#1 \\$string of static method EzSystems\\\\EzRecommendationClient\\\\Helper\\\\ParamsConverterHelper\\:\\:getArrayFromString\\(\\) expects string, bool\\|float\\|int\\|string\\|null given\\.$#"
count: 1
path: src/bundle/Controller/ContentController.php

Expand All @@ -50,6 +50,11 @@ parameters:
count: 1
path: src/bundle/Controller/ContentController.php

-
message: "#^Property EzSystems\\\\EzRecommendationClient\\\\SPI\\\\Content\\:\\:\\$lang \\(string\\|null\\) does not accept bool\\|float\\|int\\|string\\|null\\.$#"
count: 1
path: src/bundle/Controller/ContentController.php

-
message: "#^Method EzSystems\\\\EzRecommendationClientBundle\\\\Controller\\\\ContentTypeController\\:\\:getQuery\\(\\) has parameter \\$parameterBag with no value type specified in iterable type Symfony\\\\Component\\\\HttpFoundation\\\\ParameterBag\\.$#"
count: 1
Expand All @@ -76,7 +81,12 @@ parameters:
path: src/bundle/Controller/ContentTypeController.php

-
message: "#^Property EzSystems\\\\EzRecommendationClient\\\\SPI\\\\Content\\:\\:\\$fields \\(array\\<string\\>\\) does not accept string\\|null\\.$#"
message: "#^Property EzSystems\\\\EzRecommendationClient\\\\SPI\\\\Content\\:\\:\\$fields \\(array\\<string\\>\\) does not accept bool\\|float\\|int\\|string\\|null\\.$#"
count: 1
path: src/bundle/Controller/ContentTypeController.php

-
message: "#^Property EzSystems\\\\EzRecommendationClient\\\\SPI\\\\Content\\:\\:\\$lang \\(string\\|null\\) does not accept bool\\|float\\|int\\|string\\|null\\.$#"
count: 1
path: src/bundle/Controller/ContentTypeController.php

Expand Down Expand Up @@ -1010,11 +1020,6 @@ parameters:
count: 1
path: src/lib/Mapper/ExportRequestMapper.php

-
message: "#^Parameter \\#2 \\$default of method Symfony\\\\Component\\\\HttpFoundation\\\\InputBag\\:\\:get\\(\\) expects string\\|null, int given\\.$#"
count: 1
path: src/lib/Mapper/ExportRequestMapper.php

-
message: "#^Property EzSystems\\\\EzRecommendationClient\\\\SPI\\\\Content\\:\\:\\$fields \\(array\\<string\\>\\) does not accept string\\|null\\.$#"
count: 1
Expand Down

0 comments on commit 85e1882

Please sign in to comment.