Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: Updated Order MVC #100

Merged
merged 3 commits into from
Feb 9, 2025
Merged

Conversation

koreanMike513
Copy link
Collaborator

  • Spring Data JPA 가 아닌 Querydsl 을 사용한 foodRepositoryCustom 에 order 저장 로직을 일임하였습니다.

    • 이는 voucher 나 currency가 id로 요청이 오기 때문에 Spring Data JPA를 사용한다면 데이터베이스와 통신을 여러번 불필요하게 반복해야 되기 때문입니다.
  • 또 order 에 있던 collectionTime food 엔티티로 변경하는 것이 더 바람직하다고 생각하여 옮겼습니다.

  • 코드에 변화에 따른 test 도 작성하였습니다.

ps.

  • 앞의 food 와 동일합니다. ㅠ 다음에는 조금 더 잘 쪼개서 올리겠습니다.

@koreanMike513 koreanMike513 self-assigned this Feb 4, 2025
@koreanMike513 koreanMike513 merged commit 49d3a02 into feat/foods-add-mvc Feb 9, 2025
2 checks passed
Copy link

github-actions bot commented Feb 9, 2025

HCP Terraform Plan Output

```
Plan: 1 to add, 0 to change, 0 to destroy.
```
[HCP Terraform Plan](https://app.terraform.io/app/Joyeuse_Planete/workspaces/Joyeuse_Planete/runs/run-sCmrVksyg38uasbp)

@koreanMike513 koreanMike513 deleted the feat/orders-update-mvc branch February 9, 2025 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants