update: Added TimeConstants class #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added TimeConstants class - updated FoodRepository with new import statements
koreanMike513
force-pushed
the
update/add-time-constants
branch
from
68bd4ab to
cb67290
Compare
f-lab-troy
approved these changes
Dec 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
말씀해주신 대로 FoodRepository에 있던 시간 변수를 다른 클래스에 상수 타입으로 선언했습니다.
ps. 우선은 String 과 Integer 로 다르게 선언된 상수 시간 변수들이 있을 것이라고 가정하고 따로 만들었는데 이걸 합치는 게 좋을까요?
아니면 기존 대로 따로 두는 게 좋을까요? 합쳐서 다른 String 과 Integer를 같이 묶어둘 수 있는 nested class 를 만드는 것 까지 생각해봤는데 아무래도 복잡성이 더 증가한다고 생각해서 일단은 따로 만들어봤습니다.