Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added OrderRepositoryCustom #81

Merged
merged 16 commits into from
Jan 30, 2025
Merged

feat: Added OrderRepositoryCustom #81

merged 16 commits into from
Jan 30, 2025

Conversation

koreanMike513
Copy link
Collaborator

  • querydsl 로직을 사용한 custom repository 를 추가하였습니다.
  • test 도 우선적으로 추가 수정을 염두하면서 써보았습니다.

@koreanMike513 koreanMike513 added the enhancement New feature or request label Jan 29, 2025
@koreanMike513 koreanMike513 self-assigned this Jan 29, 2025
f-lab-troy
f-lab-troy approved these changes Jan 30, 2025
View reviewed changes
orders/src/main/java/com/f_lab/joyeuse_planete/orders/repository/OrderRepositoryCustomImpl.java Outdated
}

private BooleanExpression eqStatus(String status) {
return (status != null && !status.equals("ALL"))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

왜 all은 체크대상이 되지 않는지 명확하지가 않습니다

orders/src/test/java/com/f_lab/joyeuse_planete/orders/repository/OrderRepositoryTest.java Outdated
}

@Test
@DisplayName("AAA")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Production에 merge할 수 없는 draft는 mr에 포함 안시키는게 좋습니다

orders/src/test/java/com/f_lab/joyeuse_planete/orders/repository/OrderRepositoryTest.java Outdated
List<Order> orders = new ArrayList<>();

for (int i = 1; i <= 20; i++) {
OrderStatus status = (i % 3 == 0) ? OrderStatus.READY : (i % 2 == 0 ? OrderStatus.IN_PROGRESS : OrderStatus.DONE);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

전반적인 로직에 magic number와 연산이 많아 의도를 파악하기가 힘듭니다

@koreanMike513 koreanMike513 merged commit 7d9a224 into feature/orders-querydsl Jan 30, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f-lab-troy f-lab-troy f-lab-troy approved these changes

Assignees

@koreanMike513 koreanMike513

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koreanMike513 @f-lab-troy