feat: Added requests, responses, and search conditions #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f-lab-troy
reviewed
Feb 5, 2025
| public class FoodSearchCondition { | ||
| // TODO 거리 추가 구현 | ||
| // 위도 경도 DEFAULT SET TO LONDON | ||
| Double lat = 51.5072; |
| @Getter @Setter | ||
| @NoArgsConstructor | ||
| @AllArgsConstructor | ||
| public class UpdateFoodRequestDTO { |
There was a problem hiding this comment.
Create 때 사용되는 DTO의 재사용 또는 중복을 줄일 수 있는 방법을 고민해보시면 좋습니다.
| @@ -41,16 +39,56 @@ public class FoodDTO { | |||
| @JsonProperty("currency_symbol") | |||
| private String currencySymbol; | |||
|
|
|||
| @JsonProperty("rate") | |||
| private double rate; | |||
| return new PageImpl<>(result, pageable, count); | ||
| } | ||
|
|
||
| private BooleanExpression eqFoodName(String search) { |
| return (search != null) ? food.store.name.containsIgnoreCase(search) : null; | ||
| } | ||
|
|
||
| private OrderSpecifier[] getOrders(List<String> sortBy) { |
|
|
||
| @Transactional | ||
| public void createFood(CreateFoodRequestDTO request) { | ||
| Currency currency = findCurrency(request.getCurrencyCode()); |
There was a problem hiding this comment.
이건 가게 입장에서 음식을 등록할 때 결제 화폐까지 등록하는 것을 생각하고 넣었습니다.
만약 저희가 지원하지 않는 화폐를 등록하려고 할 때는 등록하지 않게 설정 하려고 했습니다만 지우도록 하겠습니다.
| @Transactional | ||
| public void updateFood(Long foodId, UpdateFoodRequestDTO request) { | ||
| Food food = findFood(foodId); | ||
| Currency currency = findCurrency(request.getCurrencyCode()); |
HCP Terraform Plan Output |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ps.