[#7] 선택 화면(장르 선택) 구현 #15

NORIKIM · 2025-01-27T16:06:34Z

장르 선택 화면(GenreView)을 구현하였습니다.
API 통신부, 이전 화면이동 버튼을 구현하였습니다.
영화, 드라마 선택을 enum으로 수정였습니다.

abdul0986 · 2025-01-28T01:29:00Z

TodayVideo/TodayVideo/ContentView/ContentView.swift

+                UserDefaults.standard.setValue(Content.movie.rawValue, forKey: UserdefaultKey.selectContent.rawValue)
                self.tvButton.isSelected = false
                self.tvButton.updateState()
                self.movieButton.updateState()
            } else {
-                self.selectedContent = self.tv
+                UserDefaults.standard.setValue(Content.tv.rawValue, forKey: UserdefaultKey.selectContent.rawValue)


func contentsSelectEvent(o1: FilterButton, o2: FilterButton) { ... o1.updateState() o2.isSelected = false o2.tvButton.updateState() } ... if sender == self.movieButton { contentsSelectEvent(self.movieButton, self.tvButton) } else { contentsSelectEvent(self.tvButton, self.movieButton) }

abdul0986 · 2025-01-28T01:48:05Z

TodayVideo/TodayVideo/GenreView/GenreInterator/GenreInteractor.swift

+class GenreInteractor: GenreInteractorProtocol {
+    var presenter: GenrePresenterProtocol?
+
+    func fetchGenres() {


Suggested change

func fetchGenres() {

func fetchGenres(presenter: GenrePresenterProtocol?) {

}

abdul0986 · 2025-01-28T01:54:34Z

TodayVideo/TodayVideo/GenreView/GenreRouter.swift

+    static func createGenreViewModule() -> GenreView {
+        let view = GenreView()
+        let presenter = GenrePresenter()
+        let router = GenreRouter()
+        let interactor = GenreInteractor()
+
+        view.presenter = presenter
+        presenter.router = router
+        presenter.interator = interactor
+        presenter.view = view
+        router.genreView = view
+        interactor.presenter = presenter
+
+        return view
+    }


Static Factory Method(A.K.A Class Factory) 패턴을 적용하신 이유가 궁금합니다.

abdul0986 · 2025-01-28T01:57:57Z

TodayVideo/TodayVideo/GenreView/GenreView.swift

+}
+
+
+


//MARK 디렉터를 달아주시길 요청드립니다.

abdul0986 · 2025-01-28T01:58:27Z

TodayVideo/TodayVideo/GenreView/GenreView.swift

+
+
+extension GenreView: GenreViewProtocol {
+    func makeGenreButton(_ genres: [Genre]) {


SRP를 준수할 수 있도록 리팩토링 부탁드립니다.

abdul0986 · 2025-01-28T02:01:13Z

TodayVideo/TodayVideo/Network/Network.swift

+
+import Foundation
+
+class Network {


Why not final class?

abdul0986 · 2025-01-28T02:01:45Z

TodayVideo/TodayVideo/Network/Network.swift

+    private enum BaseUrl: String {
+        case movieGenre = "https://api.themoviedb.org/3/genre/movie/list"
+        case TVGenre = "https://api.themoviedb.org/3/genre/tv/list"
+    }
+


이 값들이 반드시 코드 안에 리터럴로 들어가 있어야 하는지 생각해봐주세요

abdul0986 · 2025-01-28T02:07:28Z

TodayVideo/TodayVideo/Network/Network.swift

+
+import Foundation
+
+class Network {


Network 클래스는 네트워크 통신에 관련된, 혹은 API 호출 스펙에 관련된 Infrastructure 레이어만 담당하도록 해주세요

abdul0986

수정 부탁드립니다.

NORIKIM · 2025-02-04T08:19:56Z

피드백 반영하여 수정했습니다~

abdul0986

추가 수정 요청 사항이 있습니다. 확인 부탁드립니다.

abdul0986 · 2025-02-07T23:15:10Z

TodayVideo/TodayVideo/Network/Endpoint/Requestable.swift

+        if let bodyParameters = try bodyParameters?.toDictionary() {
+            if !bodyParameters.isEmpty {
+                urlRequest.httpBody = try? JSONSerialization.data(withJSONObject: bodyParameters)
+            }
+        }


이 부분도 bodyParameters를 입력받아 urlRequest.httpBody를 리턴하는 함수로 분리 가능할 것 같습니다.

abdul0986 · 2025-02-07T23:16:19Z

TodayVideo/TodayVideo/Network/Endpoint/Requestable.swift

+}
+
+extension Requestable {
+    func getUrlRequest() throws -> URLRequest {


getUrlRequest()에서 너무 많은 일을 하고 있는 것은 아닌지 생각해봐주세요.

abdul0986 · 2025-02-07T23:16:57Z

TodayVideo/TodayVideo/Network/Endpoint/Requestable.swift

+        return urlRequest
+    }
+
+    func url() throws -> URL {


url() 함수도 좀더 작은 단위로 쪼갠다면 단일 책임 원칙을 훨씬 잘 준수할 수 있을 것 같습니다.

abdul0986 · 2025-02-07T23:19:50Z

TodayVideo/TodayVideo/Network/Network.swift

+        if let error = error {
+            completion(.failure(error))
+            return
+        }
+
+        guard let response = response as? HTTPURLResponse else {
+            completion(.failure(NetworkError.unknownError))
+            return
+        }
+
+        guard (200 ... 299).contains(response.statusCode) else {
+            completion(.failure(NetworkError.invalidHttpStatusCode(response.statusCode)))
+            return
+        }
+
+        guard let data = data else {
+            completion(.failure(NetworkError.emptyData))
+            return
+        }
+
+        completion(.success((data)))


if와 guard 구문을 써서 return을 처리하셨는데요, 보통 guard 구문은 if 구문보다 먼저 사용되도록 구조를 잡는 것이 좋습니다.

위와 같은 구성에서는 checkError() 하나가 너무 여러 타입의 처리를 담당하고 있는 듯 합니다. Overload 되도록 여러 타입으로 구성된 다양한 checkError()를 쪼개서 정의하는 게 어떨까요?

NORIKIM · 2025-02-09T13:59:00Z

피드백 재반영 하였습니다. 🙂

abdul0986

LGTM

sonarqubecloud · 2025-02-10T06:06:01Z

Quality Gate passed

Issues
10 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

NORIKIM added 7 commits January 19, 2025 23:12

feat/genreView 구현 중

0bfa3a4

fix/PR 코드 리뷰 반영

66d0ffe

아이콘 이미지, 앱 이름 적용

98632f5

snapKit 업데이트

763a9c7

FIX/Fillter버튼 속성 수정

ac04a6e

REFACT/영화,드라마 enum 분리

f6400c0

장르 선택 화면 구현

de7d3e1

NORIKIM requested a review from abdul0986 January 28, 2025 01:06

NORIKIM self-assigned this Jan 28, 2025

NORIKIM added the feature label Jan 28, 2025

NORIKIM added this to the 오늘뭐봄 milestone Jan 28, 2025

NORIKIM linked an issue Jan 28, 2025 that may be closed by this pull request

선택 화면(장르 선택) 구현 #7

Closed

4 tasks

abdul0986 reviewed Jan 28, 2025

View reviewed changes

TodayVideo/TodayVideo/GenreView/GenreView.swift Outdated

}

Copy link

abdul0986 Jan 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

//MARK 디렉터를 달아주시길 요청드립니다.

abdul0986 reviewed Jan 28, 2025

View reviewed changes

TodayVideo/TodayVideo/Network/Network.swift Outdated

import Foundation

class Network {

Copy link

abdul0986 Jan 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not final class?

abdul0986 reviewed Jan 28, 2025

View reviewed changes

abdul0986 suggested changes Jan 28, 2025

View reviewed changes

fix/피드백 반영

02d4a49

NORIKIM force-pushed the feat/#7-genreView branch from 7e31dfe to 10c8929 Compare February 4, 2025 06:23

NORIKIM added 2 commits February 4, 2025 17:03

refact/네트워크 통신 부 변경

72b2f6c

fix/pod 버전 동기화

a0dd928

NORIKIM force-pushed the feat/#7-genreView branch from 10c8929 to a0dd928 Compare February 4, 2025 08:13

abdul0986 suggested changes Feb 7, 2025

View reviewed changes

fix/피드백 반영

740d0cd

abdul0986 approved these changes Feb 10, 2025

View reviewed changes

Merge branch 'main' into feat/#7-genreView

7c9ebcb

NORIKIM merged commit a510735 into main Feb 10, 2025
2 checks passed

NORIKIM deleted the feat/#7-genreView branch February 10, 2025 07:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[#7] 선택 화면(장르 선택) 구현 #15

[#7] 선택 화면(장르 선택) 구현 #15

NORIKIM commented Jan 27, 2025

abdul0986 Jan 28, 2025 •

edited

Loading

abdul0986 Jan 28, 2025

abdul0986 Jan 28, 2025

abdul0986 Jan 28, 2025

abdul0986 Jan 28, 2025

abdul0986 Jan 28, 2025

abdul0986 Jan 28, 2025

abdul0986 Jan 28, 2025

abdul0986 left a comment

NORIKIM commented Feb 4, 2025

abdul0986 left a comment

abdul0986 Feb 7, 2025

abdul0986 Feb 7, 2025

abdul0986 Feb 7, 2025

abdul0986 Feb 7, 2025

NORIKIM commented Feb 9, 2025

abdul0986 left a comment

sonarqubecloud bot commented Feb 10, 2025



		extension GenreView: GenreViewProtocol {
		func makeGenreButton(_ genres: [Genre]) {

[#7] 선택 화면(장르 선택) 구현 #15

[#7] 선택 화면(장르 선택) 구현 #15

Conversation

NORIKIM commented Jan 27, 2025

abdul0986 Jan 28, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

abdul0986 left a comment

Choose a reason for hiding this comment

NORIKIM commented Feb 4, 2025

abdul0986 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

NORIKIM commented Feb 9, 2025

abdul0986 left a comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Feb 10, 2025

Quality Gate passed

abdul0986 Jan 28, 2025 •

edited

Loading