Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[51-1-test-container-적용] #128

Merged
merged 2 commits into from
Dec 2, 2024
Merged

[51-1-test-container-적용] #128

merged 2 commits into from
Dec 2, 2024

Conversation

ScottSung7
Copy link
Collaborator

변경사항

  • Member MS의 통합테스트 중하나에 테스트 컨테이너를 적용해 보았습니다.
  • 통합테스트가 빌드때 들어가니 빌드 시간은 늘었지만, 통합테스트는 따로 db를 띄워 놓지 않으면 빌드가 안 됬는데, 이제 남겨 놓을 수 있다는 점이 좋은 것 같습니다.

@ScottSung7 ScottSung7 requested a review from heeve1 November 18, 2024 14:41
@ScottSung7 ScottSung7 self-assigned this Nov 18, 2024
heeve1
heeve1 approved these changes Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@heeve1 heeve1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저도 testContainer로 구성하면 다른 분들도 쉽게 프로젝트를 부트업할 수 있다는 장점이 크게 느껴져서 좋더라구요. 약간 디비가 뜨는 것으로인해 느려지는 부분은 withReuse를 사용하면 조금 완화할 수 있습니다.

@ScottSung7 ScottSung7 merged commit 53f8bf9 into 50-Jacoco-적용 Dec 2, 2024
@ScottSung7
Copy link
Collaborator Author

with Reuse도 사용해 보겠습니다! #161

@ScottSung7 ScottSung7 mentioned this pull request Dec 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heeve1 heeve1 heeve1 approved these changes

Assignees

@ScottSung7 ScottSung7

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ScottSung7 @heeve1