Feature/1 #2
Open
Feature/1 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 선택적으로 정렬을 사용가능한 쿼리 추가
페이지네이션, 상품 이름과 내용을 조건으로 사용하고 정렬 적용이 가능하고 기초적인 필터(품절 여부)를 포함한 상품 검색 기능 구현 Fixes : #1
f-lab-sky01
reviewed
Feb 7, 2025
|
|
||
| import java.util.Objects; | ||
|
|
||
| @Entity |
f-lab-sky01
reviewed
Feb 7, 2025
| import org.springframework.web.bind.annotation.RequestParam; | ||
| import org.springframework.web.bind.annotation.RestController; | ||
|
|
||
| @RestController |
f-lab-sky01
reviewed
Feb 7, 2025
|
|
||
| @RestController | ||
| public class ProductController { | ||
| private ProductService productService; |
There was a problem hiding this comment.
private final ProductService productService;
f-lab-sky01
reviewed
Feb 7, 2025
| import org.springframework.stereotype.Service; | ||
|
|
||
| @Service | ||
| public class ProductServiceImpl implements ProductService { |
f-lab-sky01
reviewed
Feb 7, 2025
| import java.util.Objects; | ||
|
|
||
| @Entity | ||
| public class Product { |
f-lab-sky01
reviewed
Feb 7, 2025
| ) { | ||
| Page<Product> products = productService.getProducts(name, description, isOnlyExist, pageable); | ||
|
|
||
| return new ResponseEntity<>(products, HttpStatus.OK); |
There was a problem hiding this comment.
return new ResponseEntity<>(productService.getProducts(name, description, isOnlyExist, pageable), HttpStatus.OK);
f-lab-sky01
reviewed
Feb 7, 2025
|
|
||
| @Override | ||
| public Product getProduct(long id) { | ||
| return productRepository.findById(id).orElseThrow(); |
There was a problem hiding this comment.
orElseThrow(() -> new Exception("해당하는 id 에 값이 없습니다."))
f-lab-sky01
reviewed
Feb 7, 2025
|
|
||
| @Override | ||
| public Page<Product> getProducts(String name, String description, boolean isOnlyExist, Pageable pageable) { | ||
| return productRepository.findAllByNameOrDescriptionOrStockGreaterThanEqual(name, description, isOnlyExist ? 1 : 0, pageable); |
There was a problem hiding this comment.
productRepository.findAllByNameOrDescriptionOrStockGreaterThanEqual(name, description, isOnlyExist, pageable);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.