Feat/signup #4
Feat/signup #4
Conversation
|
SonarCloudμμ μ½λ λΆμν κ²°κ³Όμ λν΄μλ μ½κ³ μμ ν΄μ£Όμλ©΄ λ μ’μκ² κ°μμ |
src/app/auth/signup/page.tsx
Outdated
| import { useState } from "react"; | ||
| import Popup from "@/app/components/common/Popup"; | ||
|
|
||
| const page = () => { |
There was a problem hiding this comment.
νμ΄μ§ μ»΄ν¬λνΈλ κΈ°λ₯κ³Ό λ μ΄μμ μ»΄ν¬λνΈλ€μ μ‘°ν©μΌλ‘ ꡬμ±λκ²λ μ½λλ₯Ό λΆν ν΄λ³΄μλ©΄ μ΄λ¨κΉμ?
src/app/my/page.tsx
Outdated
| const router = useRouter(); | ||
| const [goal, setGoal] = useState<string>(""); | ||
| const onClick = () => { | ||
| localStorage.removeItem("login"); |
There was a problem hiding this comment.
λ‘컬μ€ν 리μ§λ key:value κ΄κ³λ‘ κΌ νμν keyλ§ μ¬μ©λκ²λ νμ μΌλ‘ μ격νκ² μ νν μλ μμκ² κ°μ΅λλ€~! μμ νκ² μ¬μ©νλ €λ©΄ νμ μ€ν¬λ¦½νΈλ₯Ό μ΄λ»κ² νμ©νλκ²μ΄ μ’μκΉμ?
There was a problem hiding this comment.
λ§μμ£Όμ λ΄μ©μΌλ‘ 리뷰 λ°μνμ΅λλ€ !! :)
sonarCloudμμ λνλ κ²°κ³Όμ λν΄μ μμ νμ΅λλ€! κ°κ³Όνλ λΆλΆ, λͺ°λλ λΆλΆμ μ½ μ°μ΄μ€μ νΈν λꡬλ€μ γ γ |
src/app/store/login/loginStore.ts
Outdated
| import { create } from "zustand"; | ||
|
|
||
| type LoginStore = { | ||
| loginPopup: boolean; |
There was a problem hiding this comment.
boolean νμ μ λ³μμ΄λ¦μ is~μ κ°μ΄ μ½λ©μ»¨λ²€μ μ μ°Έκ³ ν΄μ λ€λ₯΄κ² νννμλ©΄ μ’μκ±°κ°μμ
airbnbλ googleκ³Ό κ°μ κ³³μ javascript convention λ¬Έμλ₯Ό μ½μ΄λ³΄μμ£
src/app/store/login/loginStore.ts
Outdated
| set(() => ({ loginPopup: state })); | ||
| }, | ||
| loginMessage: null, | ||
| setLoginMessage: (state) => { |
There was a problem hiding this comment.
immer λΌμ΄λΈλ¬λ¦¬λ₯Ό κ°μ΄ νμ©ν΄μ£Όμλ©΄ μ΄λ¨κΉμ?
μ μ¬μ©ν΄μΌνλμ§λ λ΄μ£Όμλ©΄ μ’μκ² κ°λ€μ!
src/app/login/loginPage.tsx
Outdated
| <LoginForm /> | ||
| </article> | ||
|
|
||
| {/* <LoginBox |
There was a problem hiding this comment.
λΉμ₯ κ°λ°ν κ² μλλΌλ©΄ μ§μ°λκ² λ«μ΅λλ€ γ γ
src/app/login/hook/useAuth.ts
Outdated
| if (data) { | ||
| const getAuthInfo = localStorageGetItem("signin"); | ||
|
|
||
| if (getAuthInfo) { |
There was a problem hiding this comment.
λΆκΈ°λ¬Έ μ€μ²©μ μ§μνμμ£ !
보νΈκ΅¬λ¬Έ μ΄λΌλ 리ν©ν λ§μ μ μ©ν΄λ³΄μμ£
src/app/components/common/Popup.tsx
Outdated
| @@ -2,7 +2,7 @@ import { popupContents, popupWrapper } from "@/app/styles/common/popup.css"; | |||
| import { paragraph2, semiBold } from "@/app/styles/font.css"; | |||
| import { flexSprinklesFc } from "./utils/flex"; | |||
|
|
|||
| const Popup = ({ text, children }: { text: string; children: React.ReactNode }) => { | |||
| const Popup = ({ text, children }: { text: null | string; children: React.ReactNode }) => { | |||
There was a problem hiding this comment.
zodλ₯Ό μ¬μ©νλ©΄ nullish νμ μΌλ‘ ννν μλ μμκ² κ°μμ
νμ μλ nullish(optional), nullableκ°μ ννμ νμ λ μμΌλ νμ©ν΄λ³΄μλ건 μ΄λ¨κΉμ
|
|
λ©ν λκ»μ λ§μμ£Όμ reviewλ€μ λ°νμΌλ‘ 리ν©ν λ§ λ° λΌμ΄λΈλ¬λ¦¬λ₯Ό μΆκ°νμ΅λλ€ κ°μ¬ν©λλ€ ~~ :D |
π κ΄λ ¨ μ΄μ
νμκ°μ / λ‘κ·ΈμΈ κ΄λ ¨ νμ΄μ§μ λλ€.
π μμ λ΄μ©
π PR Point
πΈ μ€ν¬λ¦°μ· λλ GIF(option)