질문 도메인의 API, Service 기능 구현 및 테스트 작성 #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- lombok 추가 - group: com.family 설정 - root project submodule 제거
Test Results8 tests 8 ✅ 1s ⏱️ Results for commit aa87ef1. ♻️ This comment has been updated with latest results. |
f-lab-lyan
reviewed
Sep 4, 2024
.github/workflows/ci.yml
Outdated
| ${{ runner.os }}-gradle- | ||
|
|
||
| # gradle 실행 허가 | ||
| - name: Run chmod to make gradlew executable |
There was a problem hiding this comment.
리포지토리에 gradlew파일의 실행권을 주면 좋을 것 같습니다.
f-lab-lyan
reviewed
Sep 4, 2024
.github/workflows/ci.yml
Outdated
| java-version: '17' | ||
| distribution: 'adopt' | ||
|
|
||
| - name: Gradle Caching |
There was a problem hiding this comment.
gradle action을 쓰면, 이 부분은 해결이 됩니다.
f-lab-lyan
reviewed
Sep 4, 2024
.github/workflows/ci.yml
Outdated
| - name: Run chmod to make gradlew executable | ||
| run: chmod +x ./gradlew | ||
|
|
||
| - name: 빌드 진행 |
There was a problem hiding this comment.
이 workflow에서는 빌드까지는 할 필요없을 것 같고, 테스트만 잘 되면 될 것 같습니다.
f-lab-lyan
reviewed
Sep 4, 2024
.github/workflows/ci.yml
Outdated
| uses: mikepenz/action-junit-report@v3 | ||
| if: success() || failure() # always run even if the previous step fails | ||
| with: | ||
| report_paths: '**/build/test-results/test/TEST-*.xml' |
f-lab-lyan
reviewed
Sep 4, 2024
module-stream/build.gradle
Outdated
There was a problem hiding this comment.
스트림 모듈을 어떻게 사용할 것인지 궁금합니다.
f-lab-lyan
reviewed
Sep 4, 2024
There was a problem hiding this comment.
이 파일은 크게 필요는 없을 것 같으니, 빼는게 좋을 것 같아요.
f-lab-lyan
reviewed
Sep 4, 2024
|
|
||
| @Service | ||
| @RequiredArgsConstructor | ||
| public class QuestionFacade { |
There was a problem hiding this comment.
Facade를 따로 만드는 이유가 있을까요?
- gradle actions 적용 - 불필요한 build step 제거 - 테스트 실패시에만 결과 코멘트 작성
f-lab-lyan
approved these changes
Sep 8, 2024
f-lab-lyan
reviewed
Sep 8, 2024
| group = 'com.family' |
There was a problem hiding this comment.
다른 PR에서 마지막에 새 줄 하나 추가해주세요.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todos
close #3