세팅 뷰 추가 #58
Merged
세팅 뷰 추가 #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
MojitoBar
commented
Dec 27, 2023
MojitoBar
commented
- 로그아웃을 세팅 뷰로 분리했습니다.
- 세팅 뷰의 항목을 클릭하면 한 번 더 확인하는 팝업이 뜨는 기능을 추가했습니다.
- 이미지에 디스크캐싱을 적용했습니다.
- 세팅뷰에서 디스크캐싱의 현황을 확인하고 삭제하는 기능을 추가헀습니다.
f-lab-jercy
approved these changes
Jan 2, 2024
|
|
||
| private func performInitialDataPopulation() { | ||
| var snapshot = NSDiffableDataSourceSnapshot<Int, String>() | ||
| snapshot.appendSections([0]) |
There was a problem hiding this comment.
섹션은 상수값이 아닌 enum으로 관리해서 이름도 명확하게 해보면 어떨까요?
| private func configureDiffableDataSource() { | ||
| dataSource = UITableViewDiffableDataSource<Int, String>(tableView: tableView, cellProvider: { [weak self] tableView, indexPath, _ in | ||
| guard let self else { fatalError("self is nil") } | ||
| let cell = tableView.dequeueReusableCell(withIdentifier: "SettingViewCell", for: indexPath) as? SettingViewCell |
There was a problem hiding this comment.
cell을 생성하는 영역도 어떻게 공통코드로 빼서 단순화 시켜볼수 있지 않을까요?
| } | ||
|
|
||
| private func configureDiffableDataSource() { | ||
| dataSource = UITableViewDiffableDataSource<Int, String>(tableView: tableView, cellProvider: { [weak self] tableView, indexPath, _ in |
There was a problem hiding this comment.
UITableViewDiffableDataSource<Int, String> 이러한 부분은 typealias를 이용해서 단순하게 만들어 볼 수 있을것 같습니다.
pins/Utils/DiskCacheManager.swift
Outdated
| enum DiskCacheManager { | ||
| static func cacheImage(_ image: UIImage, withFilename filename: String) { | ||
| let hash = CryptoUtils.sha256(filename) | ||
| if let data = image.jpegData(compressionQuality: 1.0) ?? image.pngData() { |
There was a problem hiding this comment.
jpeg는 1.0보다는 보통 0.7을 많이 사용하는 편이긴합니다.
https://stackoverflow.com/questions/26330492/what-should-compressionquality-be-when-using-uiimagejpegrepresentation
|
코드리뷰 남겨주신 내용 각각 커밋으로 반영해봤습니다 ! |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.