Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

전체 리뷰 반영 PR #59

Merged
merged 17 commits into from
Jan 3, 2024
Merged

전체 리뷰 반영 PR #59

merged 17 commits into from
Jan 3, 2024

Conversation

MojitoBar
Copy link
Collaborator

남겨주신 전체 코드리뷰 반영 PR 입니다 !

코드리뷰 댓글에 commit 링크 연결했습니다 !

@MojitoBar MojitoBar self-assigned this Dec 31, 2023
@MojitoBar MojitoBar changed the title Feature/review reflect 전체 리뷰 반영 PR Dec 31, 2023
Copy link

@f-lab-jercy f-lab-jercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!
한가지만 더 추가해보면 좋을거 같은데, 사용성을 위해서 에러를 받았을때, fatalError나 OSlog만 남기지말고 사용자에게도 문제가 발생했다는 점을 알려주면 좋을것 같습니다.

토스트나 알럿 등등 다양한 방법이 있을듯 한데 한번 어떤방법과 어떻게 내용을 표시하면 좋을지 고민한뒤에 적용을 해봅시다.

Copy link

sonarqubecloud bot commented Jan 3, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

5 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.9% Duplication on New Code

See analysis details on SonarCloud

@MojitoBar MojitoBar merged commit f5c9f9f into main Jan 3, 2024
3 checks passed
@MojitoBar MojitoBar deleted the feature/review-reflect branch January 3, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants