Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: introduce SPOT VMs policy #433

Merged
merged 1 commit into from
May 5, 2024
Merged

planner: introduce SPOT VMs policy #433

merged 1 commit into from
May 5, 2024

Conversation

csegarragonz
Copy link
Collaborator

No description provided.

@csegarragonz csegarragonz force-pushed the spot branch 8 times, most recently from bce45b4 to e391216 Compare April 28, 2024 16:47
@csegarragonz csegarragonz marked this pull request as ready for review April 28, 2024 16:50
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 63.71429% with 127 lines in your changes are missing coverage. Please review.

Project coverage is 81.33%. Comparing base (35af765) to head (621fdfc).

Files Patch % Lines
src/planner/Planner.cpp 37.31% 84 Missing ⚠️
src/executor/Executor.cpp 0.00% 17 Missing ⚠️
src/scheduler/Scheduler.cpp 33.33% 14 Missing ⚠️
src/planner/PlannerEndpointHandler.cpp 85.36% 6 Missing ⚠️
src/batch-scheduler/SpotScheduler.cpp 96.15% 5 Missing ⚠️
include/faabric/util/func.h 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #433      +/-   ##
==========================================
- Coverage   82.25%   81.33%   -0.93%     
==========================================
  Files         116      117       +1     
  Lines        7901     8233     +332     
==========================================
+ Hits         6499     6696     +197     
- Misses       1402     1537     +135     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@csegarragonz csegarragonz force-pushed the spot branch 6 times, most recently from d462642 to cb189be Compare May 4, 2024 14:49
@csegarragonz csegarragonz merged commit ddba013 into main May 5, 2024
11 of 12 checks passed
@csegarragonz csegarragonz deleted the spot branch May 5, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant